[jira] [Commented] (HBASE-6282) The introspection, etc. of objects in the RPC has to be handled for PB objects

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497668#comment-13497668 ] 

stack commented on HBASE-6282:
------------------------------

If I enable IPC trace, its not bad as is:

{code}
...e.hadoop.ipc.HBaseServer.trace: Call #18; Served: ClientProtocol#multi queueTime=1 processingTime=0 contents=1 MultiRequest
{code}

I can call toString on the pb param.  This is totally obnoxious but would be a nice option to have debugging.  Let me post a patch.

Regards the logResponse, that needs fixup in general.  I had it recently and found the message reported close to useless.  Lets file a new issue to fix that distinct from pb'ing.
                
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-6282
>                 URL: https://issues.apache.org/jira/browse/HBASE-6282
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC
>            Reporter: Devaraj Das
>            Priority: Blocker
>             Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira