You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/02/04 13:12:35 UTC

(skywalking-banyandb-helm) branch master updated: Update flags for the fodc agent (#51)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git


The following commit(s) were added to refs/heads/master by this push:
     new 553ce83  Update flags for the fodc agent (#51)
553ce83 is described below

commit 553ce835703b3a4618345461a167776ebe8de9e1
Author: Fine0830 <fa...@gmail.com>
AuthorDate: Wed Feb 4 21:12:29 2026 +0800

    Update flags for the fodc agent (#51)
    
    * update flags for fodc
    
    * update parameters and standalone
---
 chart/templates/cluster_data_statefulset.yaml    |  3 ++-
 chart/templates/cluster_liaison_statefulset.yaml |  3 ++-
 chart/templates/standalone_statefulset.yaml      |  3 ++-
 chart/values.yaml                                |  2 ++
 doc/parameters.md                                | 13 +++++++++----
 test/e2e/e2e-banyandb-fodc-proxy-service.yaml    |  2 +-
 test/e2e/values.fodc.yaml                        |  5 +++--
 7 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/chart/templates/cluster_data_statefulset.yaml b/chart/templates/cluster_data_statefulset.yaml
index 24283bc..c10d15a 100644
--- a/chart/templates/cluster_data_statefulset.yaml
+++ b/chart/templates/cluster_data_statefulset.yaml
@@ -311,8 +311,9 @@ spec:
             - --pod-name=$(POD_NAME)
             - --container-names=data,lifecycle
             - --poll-metrics-ports=2121,17915
-            - --node-role=datanode-{{ $roleName }}
+            - --cluster-state-ports=17912,17914
             - --poll-metrics-interval={{ $.Values.cluster.fodc.agent.config.pollMetricsInterval }}
+            - --cluster-state-poll-interval={{ $.Values.cluster.fodc.agent.config.pollClusterStateInterval }}
             - --prometheus-listen-addr=:{{ $.Values.cluster.fodc.agent.metricsPort }}
             - --max-metrics-memory-usage-percentage={{ $.Values.cluster.fodc.agent.config.ktmEnabled | ternary 20 10 }}
             - --heartbeat-interval={{ $.Values.cluster.fodc.agent.config.heartbeatInterval }}
diff --git a/chart/templates/cluster_liaison_statefulset.yaml b/chart/templates/cluster_liaison_statefulset.yaml
index f0f0333..4ffb8d1 100644
--- a/chart/templates/cluster_liaison_statefulset.yaml
+++ b/chart/templates/cluster_liaison_statefulset.yaml
@@ -301,7 +301,8 @@ spec:
             - --pod-name=$(POD_NAME)
             - --container-names=liaison
             - --poll-metrics-ports=2121
-            - --node-role=liaison
+            - --cluster-state-ports=18912
+            - --cluster-state-poll-interval={{ .Values.cluster.fodc.agent.config.pollClusterStateInterval }}
             - --poll-metrics-interval={{ .Values.cluster.fodc.agent.config.pollMetricsInterval }}
             - --prometheus-listen-addr=:{{ .Values.cluster.fodc.agent.metricsPort }}
             - --max-metrics-memory-usage-percentage={{ .Values.cluster.fodc.agent.config.ktmEnabled | ternary 20 10 }}
diff --git a/chart/templates/standalone_statefulset.yaml b/chart/templates/standalone_statefulset.yaml
index 5e2f47e..4935aa8 100644
--- a/chart/templates/standalone_statefulset.yaml
+++ b/chart/templates/standalone_statefulset.yaml
@@ -248,8 +248,9 @@ spec:
             - --proxy-addr={{ template "banyandb.fullname" . }}-fodc-proxy-grpc:{{ .Values.cluster.fodc.proxy.grpcSvc.port }} \
             - --pod-name=$(POD_NAME)
             - --container-names=standalone
-            - --node-role=standalone
             - --poll-metrics-ports=2121
+            - --cluster-state-ports=17912
+            - --cluster-state-poll-interval={{ .Values.cluster.fodc.agent.config.pollClusterStateInterval }}
             - --poll-metrics-interval={{ .Values.cluster.fodc.agent.config.pollMetricsInterval }}
             - --prometheus-listen-addr=:{{ .Values.cluster.fodc.agent.metricsPort }}
             - --max-metrics-memory-usage-percentage={{ .Values.cluster.fodc.agent.config.ktmEnabled | ternary 20 10 }}
diff --git a/chart/values.yaml b/chart/values.yaml
index 9fb5aa8..f6a087f 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -994,6 +994,8 @@ cluster:
         reconnectInterval: 10s
         ## @param cluster.fodc.agent.config.ktmEnabled Enable Kernel Telemetry Module (affects max-metrics-memory-usage-percentage)
         ktmEnabled: true
+        ## @param cluster.fodc.agent.config.pollClusterStateInterval Interval for polling cluster state from Proxy (poll-cluster-state-interval flag)
+        pollClusterStateInterval: 30s
       ## Liveness probe for Agent
       livenessProbe:
         ## @param cluster.fodc.agent.livenessProbe.initialDelaySeconds Initial delay for Agent liveness probe
diff --git a/doc/parameters.md b/doc/parameters.md
index 507b483..b6a4b89 100644
--- a/doc/parameters.md
+++ b/doc/parameters.md
@@ -292,11 +292,16 @@ The content of this document describes the parameters that can be configured in
 | `cluster.ui.standalone.startupProbe.successThreshold`               | Success threshold for UI startup probe          | `1`             |
 | `cluster.ui.standalone.startupProbe.failureThreshold`               | Failure threshold for UI startup probe          | `60`            |
 
-### Configuration for FODC (First Occurrence Data Collection) Proxy component
+### Configuration for FODC (First Occurrence Data Collection)
+
+| Name                  | Description                           | Value  |
+| --------------------- | ------------------------------------- | ------ |
+| `cluster.fodc.enabled` | Enable FODC (both Agent and Proxy) (boolean) | `true` |
+
+### FODC Proxy component
 
 | Name                                                            | Description                                                             | Value                                             |
 | --------------------------------------------------------------- | ----------------------------------------------------------------------- | ------------------------------------------------- |
-| `cluster.fodc.proxy.enabled`                                     | Enable FODC Proxy deployment (boolean)                                  | `true`                                            |
 | `cluster.fodc.proxy.podAnnotations`                              | Pod annotations for Proxy                                               | `{}`                                              |
 | `cluster.fodc.proxy.securityContext`                             | Security context for Proxy pods                                         | `{}`                                              |
 | `cluster.fodc.proxy.containerSecurityContext`                    | Container-level security context for Proxy                              | `{}`                                              |
@@ -354,11 +359,10 @@ The content of this document describes the parameters that can be configured in
 | `cluster.fodc.proxy.startupProbe.successThreshold`               | Success threshold for Proxy startup probe                               | `1`                                               |
 | `cluster.fodc.proxy.startupProbe.failureThreshold`               | Failure threshold for Proxy startup probe                               | `60`                                              |
 
-### Configuration for FODC (First Occurrence Data Collection) Agent sidecar
+### FODC Agent sidecar
 
 | Name                                                   | Description                                                                  | Value                                             |
 | ------------------------------------------------------ | ---------------------------------------------------------------------------- | ------------------------------------------------- |
-| `cluster.fodc.agent.enabled`                            | Enable FODC Agent sidecar (boolean)                                          | `true`                                            |
 | `cluster.fodc.agent.image.repository`                   | Docker repository for FODC Agent                                             | `ghcr.io/apache/skywalking-banyandb-fodc-agent` |
 | `cluster.fodc.agent.image.tag`                          | Image tag/version for FODC Agent (defaults to same as main image)            | `""`                                              |
 | `cluster.fodc.agent.image.pullPolicy`                   | Image pull policy for FODC Agent                                             | `IfNotPresent`                                    |
@@ -371,6 +375,7 @@ The content of this document describes the parameters that can be configured in
 | `cluster.fodc.agent.config.heartbeatInterval`           | Heartbeat interval to Proxy (heartbeat-interval flag)                        | `10s`                                             |
 | `cluster.fodc.agent.config.reconnectInterval`           | Reconnect interval when connection to Proxy is lost (reconnect-interval flag) | `10s`                                             |
 | `cluster.fodc.agent.config.ktmEnabled`                  | Enable Kernel Telemetry Module (affects max-metrics-memory-usage-percentage) | `true`                                            |
+| `cluster.fodc.agent.config.pollClusterStateInterval`    | Interval for polling cluster state from Proxy (poll-cluster-state-interval flag) | `30s`                                             |
 | `cluster.fodc.agent.livenessProbe.initialDelaySeconds`  | Initial delay for Agent liveness probe                                       | `90`                                              |
 | `cluster.fodc.agent.livenessProbe.periodSeconds`        | Probe period for Agent liveness probe                                        | `30`                                              |
 | `cluster.fodc.agent.livenessProbe.timeoutSeconds`       | Timeout in seconds for Agent liveness probe                                  | `5`                                               |
diff --git a/test/e2e/e2e-banyandb-fodc-proxy-service.yaml b/test/e2e/e2e-banyandb-fodc-proxy-service.yaml
index 4120ca0..473c445 100644
--- a/test/e2e/e2e-banyandb-fodc-proxy-service.yaml
+++ b/test/e2e/e2e-banyandb-fodc-proxy-service.yaml
@@ -64,7 +64,7 @@ setup:
           for: condition=available
     - name: Install SkyWalking
       command: |
-        helm -n istio-system install --timeout 10m skywalking oci://ghcr.io/apache/skywalking-helm/skywalking-helm \
+        helm -n istio-system install --timeout 20m skywalking oci://ghcr.io/apache/skywalking-helm/skywalking-helm \
                        --version "$SW_HELM_VERSION" \
                        --set fullnameOverride=skywalking \
                        --set oap.env.SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh \
diff --git a/test/e2e/values.fodc.yaml b/test/e2e/values.fodc.yaml
index a67efd8..0db0818 100644
--- a/test/e2e/values.fodc.yaml
+++ b/test/e2e/values.fodc.yaml
@@ -266,7 +266,7 @@ cluster:
             value: 512Mi
       image:
         repository: ghcr.io/apache/skywalking-banyandb-fodc-proxy
-        tag: "67cb3eaa71d1b2ba9a56dddc17050fd69da78593"
+        tag: "931a605a47b2bbb0d171ae1ac12c466d4f3a2905"
         pullPolicy: IfNotPresent
       grpcSvc:
         labels: {}
@@ -316,7 +316,7 @@ cluster:
     agent:
       image:
         repository: ghcr.io/apache/skywalking-banyandb-fodc-agent
-        tag: "67cb3eaa71d1b2ba9a56dddc17050fd69da78593"
+        tag: "931a605a47b2bbb0d171ae1ac12c466d4f3a2905"
         pullPolicy: IfNotPresent
       env: []
       containerSecurityContext: {}
@@ -336,6 +336,7 @@ cluster:
         pollMetricsInterval: 15s
         heartbeatInterval: 10s
         ktmEnabled: true
+        pollClusterStateInterval: 30s
       livenessProbe:
         initialDelaySeconds: 90
         periodSeconds: 30