You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/06/15 04:14:53 UTC
(superset) branch master updated: fix(table): sort metric columns numerically regardless of display format (#39775)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new f88f1fad04d fix(table): sort metric columns numerically regardless of display format (#39775)
f88f1fad04d is described below
commit f88f1fad04d46cafcfd7d3b1117909f2752ae515
Author: Nitish Agarwal <15...@users.noreply.github.com>
AuthorDate: Mon Jun 15 09:44:44 2026 +0530
fix(table): sort metric columns numerically regardless of display format (#39775)
---
.../plugins/plugin-chart-table/src/TableChart.tsx | 7 +-
.../plugin-chart-table/test/TableChart.test.tsx | 77 ++++++++++++++++++++++
2 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
index 1b9c77c33ee..da80af7ae88 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -1371,7 +1371,12 @@ export default function TableChart<D extends DataRecord = DataRecord>(
)
) : undefined,
sortDescFirst: sortDesc,
- sortType: getSortTypeByDataType(dataType),
+ // Metrics and percent metrics always have numeric values; use numeric sort
+ // even if the backend reports the column type as String.
+ sortType:
+ isMetric || isPercentMetric
+ ? 'basic'
+ : getSortTypeByDataType(dataType),
};
},
[
diff --git a/superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx b/superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx
index 474298599fd..7a12f25ec92 100644
--- a/superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx
@@ -2457,3 +2457,80 @@ describe('Drill-to-Detail Temporal Range Logic', () => {
expect(filter.val).toBeNull();
});
});
+
+// Numeric values with String dataType (e.g. backend mis-reports type for computed columns)
+// get 'alphanumeric' sort, which treats raw numbers as non-strings and produces unstable order.
+// They should sort numerically regardless of display format.
+test('sorts numeric-backed percentage column numerically when dataType is String', async () => {
+ const props = transformProps({
+ ...testData.raw,
+ rawFormData: {
+ ...testData.raw.rawFormData,
+ order_desc: false,
+ metrics: ['pct'],
+ column_config: {
+ pct: { d3NumberFormat: '.1%' },
+ },
+ },
+ queriesData: [
+ {
+ ...testData.raw.queriesData[0],
+ colnames: ['pct'],
+ coltypes: [GenericDataType.String],
+ data: [
+ { pct: 0.4 },
+ { pct: 0.056 },
+ { pct: 0.506 },
+ { pct: 0.066 },
+ { pct: 0.41 },
+ ],
+ },
+ ],
+ });
+
+ render(
+ ProviderWrapper({
+ children: <TableChart {...props} sticky={false} />,
+ }),
+ );
+
+ const header = screen.getByText('pct');
+ fireEvent.click(header);
+
+ const cells = document.querySelectorAll('tbody td');
+ const values = Array.from(cells).map(td => td.textContent);
+ expect(values).toEqual(['5.6%', '6.6%', '40.0%', '41.0%', '50.6%']);
+});
+
+test('sorts genuinely string columns alphanumerically', () => {
+ const props = transformProps({
+ ...testData.raw,
+ rawFormData: {
+ ...testData.raw.rawFormData,
+ order_desc: false,
+ metrics: [],
+ columns: ['label'],
+ },
+ queriesData: [
+ {
+ ...testData.raw.queriesData[0],
+ colnames: ['label'],
+ coltypes: [GenericDataType.String],
+ data: [{ label: 'banana' }, { label: 'apple' }, { label: 'cherry' }],
+ },
+ ],
+ });
+
+ render(
+ ProviderWrapper({
+ children: <TableChart {...props} sticky={false} />,
+ }),
+ );
+
+ const header = screen.getByText('label');
+ fireEvent.click(header);
+
+ const cells = document.querySelectorAll('tbody td');
+ const values = Array.from(cells).map(td => td.textContent);
+ expect(values).toEqual(['apple', 'banana', 'cherry']);
+});