You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:02:41 UTC

[GitHub] [arrow] jorisvandenbossche commented on pull request #8462: ARROW-10145: [C++][Dataset] Assert integer overflow in partitioning falls back to string

jorisvandenbossche commented on pull request #8462:
URL: https://github.com/apache/arrow/pull/8462#issuecomment-709065744


   Thanks! So this was already fixed in partition type simplification PR (https://github.com/apache/arrow/pull/8367). The added tests look good.
   
   Now, falling back to string is certainly better as raising an error. But I am wondering: do we want to do more inference than just int32 and string? Could we infer int64 here? That might quickly get complicated / a can of worms ?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org