You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Bill Graham (JIRA)" <ji...@apache.org> on 2012/04/24 03:10:32 UTC
[jira] [Created] (PIG-2660) PPNL should get notified of plan before
it gets executed
Bill Graham created PIG-2660:
--------------------------------
Summary: PPNL should get notified of plan before it gets executed
Key: PIG-2660
URL: https://issues.apache.org/jira/browse/PIG-2660
Project: Pig
Issue Type: New Feature
Reporter: Bill Graham
Assignee: Bill Graham
The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
{code}
public void initialPlanNotification(MROperPlan plan);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2660) PPNL should get notified of plan before
it gets executed
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2660:
-----------------------------
Attachment: PIG-2660.2.patch
Cool call. I haven't heard of anyone else using PPNLs on the list yet, but I agree with the suggestion. Patch #2 attached.
I wondered if we should we take it a step further and catch Exception for all calls to a PPNL. Should a bug in a PPNL implementation cause a script to fail, possibly mid-way through execution?
If we leave things as they are now, the answer would be _yes_, unless someone implemented their PPNL defensively to make it a _no_. As such, I'm inclined to leave things as they are and put the control in the hands of the implementer.
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch, PIG-2660.2.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2660) PPNL should get notified of plan before
it gets executed
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2660:
-----------------------------
Release Note: Provide MROperPlan to PigProgressNotificationListener
Status: Patch Available (was: Open)
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2660) PPNL should get notified of plan before
it gets executed
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2660:
-----------------------------
Attachment: PIG-2660.1.patch
Attaching a patch for review.
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2660) PPNL should get notified of plan
before it gets executed
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262173#comment-13262173 ]
Dmitriy V. Ryaboy commented on PIG-2660:
----------------------------------------
I tried to find users of the PPNL interface earlier, and none were to be had (Oozie is a potential one, but they said they don't use it). There are a number of changes to this interface we want to put into 0.11, they will be documented appropriately.
Oozie asked that we implement an abstract PPNL for future-proofing, which I thought I did.. but now can't find. Outstanding jira?
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch, PIG-2660.2.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2660) PPNL should get notified of plan before
it gets executed
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated PIG-2660:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.11
Status: Resolved (was: Patch Available)
Committed.
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.11
>
> Attachments: PIG-2660.1.patch, PIG-2660.2.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2660) PPNL should get notified of plan
before it gets executed
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265581#comment-13265581 ]
Dmitriy V. Ryaboy commented on PIG-2660:
----------------------------------------
+1
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch, PIG-2660.2.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2660) PPNL should get notified of plan
before it gets executed
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265559#comment-13265559 ]
Bill Graham commented on PIG-2660:
----------------------------------
Opened PIG-2678 for creating an abstract PPNL. Unless anyone else has comments, I'll commit patch #2.
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch, PIG-2660.2.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2660) PPNL should get notified of plan
before it gets executed
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262117#comment-13262117 ]
Alan Gates commented on PIG-2660:
---------------------------------
Looks good. Do we have any idea how often people implement PigProgressNotificationListerner? I'm wondering if the calls to initialPlanNotfication in SyncProgressNotificationAdaptor and ScriptState should be wrapped with a catch for NoSuchMethodException in case people are using old listeners. Other than that, +1.
> PPNL should get notified of plan before it gets executed
> --------------------------------------------------------
>
> Key: PIG-2660
> URL: https://issues.apache.org/jira/browse/PIG-2660
> Project: Pig
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: PIG-2660.1.patch
>
>
> The {{PigProgressNotificationListner}} should get notified of the plan ({{MROperPlan}}) before it gets executed. This allows listeners to inspect the plan and have an idea what to expect in the execution flow. Proposal is to add the following method to the PPNL interface, which is marked as evolving:
> {code}
> public void initialPlanNotification(MROperPlan plan);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira