[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build

[GitBox <gi...@apache.org>]

rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951204672


   I'm not convinced this is the right thing to do. If you compare the original mvn and mvnw script when it was donated, you should have noticed that they both went their own way. It took me quite some time to get them in sync and to pick the best of both. By splitting it up it will happen again.
   Maybe you should wait with this AFTER MNG-7073 so Maven contains a script template that can be reused here.
   
   Moving the wrapper to here, does that mean that this plugin must be released every time is released too, like the takari plugin used to do? Then we've lost the benefit of the current setup, because most likely the plugin now doesn't require  new releases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org