You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/19 15:45:17 UTC
[GitHub] [beam] snkalinin commented on a change in pull request #15740: [BEAM-12936][Playground] Code editor - Docker container
snkalinin commented on a change in pull request #15740:
URL: https://github.com/apache/beam/pull/15740#discussion_r732007406
##########
File path: playground/frontend/nginx_default.conf
##########
@@ -0,0 +1,61 @@
+###############################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+
+server {
Review comment:
If we are deploy via Docker container, we will need that application inside container listen to 8080 port, and ingress on App Engine VM.
Scheme of work looks like
```
port 80 port 443
| |
\ /
| |
| |
\ /
+----|-------|-----------------------------+
| \ / |
| | | |
| | | |
| +------------+ +------------+ |
| | | port 8080 | | |
| |nginx_proxy |-----------| gaeapp | |
| | | | | |
| +------------+ +------------+ |
| |
| |
| |
| App Engine VM |
+------------------------------------------+
```
I mean, on AppEngine VM there are container called nginx_proxy, it has nginx inside and config has block
```
upstream app_server {
keepalive 192;
server gaeapp:8080;
}
```
So that's why I added slightly modified nginx default config, that listens to 8080 port instead of default 80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org