You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/14 06:50:54 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36545: [WIP][SPARK-39168][PYTHON] Use all values in a python list when inferring ArrayType schema

HyukjinKwon commented on code in PR #36545:
URL: https://github.com/apache/spark/pull/36545#discussion_r872942079


##########
python/pyspark/sql/tests/test_types.py:
##########
@@ -285,6 +285,64 @@ def test_infer_nested_dict_as_struct(self):
             df = self.spark.createDataFrame(data)
             self.assertEqual(Row(f1=[Row(payment=200.5, name="A")], f2=[1, 2]), df.first())
 
+    def test_infer_array_merge_element_types(self):

Review Comment:
   Let's add a comment like # SPARK-39168: ... (see also https://spark.apache.org/contributing.html)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org