You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "det101 (via GitHub)" <gi...@apache.org> on 2026/07/13 01:55:28 UTC

[PR] [Feature][Connector-V2] Support JDBC sink table_options for PostgreSQL [seatunnel]

det101 opened a new pull request, #11417:
URL: https://github.com/apache/seatunnel/pull/11417

   ## Purpose
   Extend JDBC sink `table_options` (SaveMode auto-create) to PostgreSQL, as a follow-up to #11047 / #11101 / #11388.
   
   ## Changes
   - Add PostgreSQL curated key whitelist: `tablespace`, `fillfactor`
   - Wire `PostgresDialect.validateTableOptions` and apply options in `PostgresCreateTableSqlBuilder` DDL (`WITH (fillfactor=...)` / `TABLESPACE "..."`)
   - OpenGauss and HighGo inherit the same path via Postgres catalog/dialect
   - Docs (en/zh): support matrix + dialect caveats + PostgreSQL example
   - Unit tests: dialect / DDL / OptionRule coverage
   
   ## Non-goals
   - Arbitrary `WITH (...)` parameters, `USING`, partition / `INHERITS`
   - `ALTER TABLE` on existing tables (`table_options` only applies when SaveMode creates the table)
   - Value-level validation beyond key whitelist (same as MySQL delivery)
   - Oracle (separate PR: #11416)
   
   ## Test plan
   - [x] `PostgresDialectTableOptionsTest`
   - [x] `PostgresCreateTableSqlBuilderTest#testBuildCreateTableSqlWithTableOptions`
   - [x] `JdbcTableOptionsConditionExtensionTest` (PostgreSQL pass / unknown-key reject)
   - [x] `PostgresDialectTest` (regression)
   - [ ] CI on this PR
   
   ## Related
   - Issue: #11047
   - MySQL: #11101
   - TiDB / OceanBase MySQL: #11388
   - Oracle: #11416
   - StarRocks: #11242
   
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for PostgreSQL [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11417:
URL: https://github.com/apache/seatunnel/pull/11417#issuecomment-4975886998

   Rechecked the latest head again from the PostgreSQL `table_options` validation/build path.
   
   The earlier Daniel source-side blockers are closed for me on this revision:
   - blank values are now rejected instead of being silently dropped;
   - `fillfactor` is now validated before SQL generation;
   - `tablespace` is no longer run through the column `fieldIde` rewriting path.
   
   So my current Daniel-side conclusion on this head is no longer "code blocker still open". The remaining gate is the current GitHub `Build` result.
   
   From the visible failing lanes on the current fork workflow, I do not see a clear source-level link from this PostgreSQL DDL/validation diff to the red top-level `Build` yet. The lowest-cost next step is to rerun `Build` on the current head first. If the refreshed run still fails, please paste the new run link and I can narrow it down from there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for PostgreSQL [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11417:
URL: https://github.com/apache/seatunnel/pull/11417#issuecomment-4968433807

   Rechecked the same unchanged head `26e772ed9609` after the CI / merge-gate fact changed.
   
   ## Runtime path rechecked
   ```text
   JDBC sink config
     -> JdbcSinkFactory.optionRule()
         -> JdbcTableOptionsConditionExtension
             -> JdbcTableOptionsValidator.validate(...)
                 -> PostgresDialect.validateTableOptions(...)
     -> save-mode auto create
         -> PostgresCreateTableSqlBuilder.build(...)
             -> append WITH (fillfactor=...) / TABLESPACE ... into CREATE TABLE
   ```
   
   ## Merge conclusion
   ### Conclusion: still needs fixes before merge
   
   1. Blocking items
   - The source-side blockers from my previous Daniel review still stand on this unchanged head.
   
   2. Current gate update
   - The CI / merge-gate fact I referenced earlier has changed. The current status is `PENDING gate: Build`: https://github.com/apache/seatunnel/runs/87012019791
   
   So my technical conclusion is unchanged on merge readiness: this PR still needs the earlier code-side fixes first.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for PostgreSQL [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11417:
URL: https://github.com/apache/seatunnel/pull/11417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org