[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1591: Rework docker connection validation, so we can find out why docker connection failed.

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1591: Rework docker connection validation, so we can find out why docker connection failed.
URL: https://github.com/apache/netbeans/pull/1591#discussion_r352359597
 
 

 ##########
 File path: ide/docker.api/src/org/netbeans/modules/docker/api/DockerAction.java
 ##########
 @@ -1004,9 +1004,8 @@ public StreamItem fetch() {
         }
     }
 
-    public boolean ping() {
+    public boolean pingWithExceptions() throws IOException, MalformedURLException {
         assert !SwingUtilities.isEventDispatchThread() : "Remote access invoked from EDT";
-        try {
             Endpoint s = createEndpoint();
 
 Review comment:
   The idention is off - please move it to the correct level (one level to the left).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists