You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Stamatis Zampetakis <za...@gmail.com> on 2019/09/02 15:15:59 UTC
[VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.21.0, release candidate 0.
Thanks to everyone who has contributed to this release.
This release comes two months after 1.20.0 and brings many bug fixes and
new
important features among others the following.
* Support for implicit casts.
* Transformation of Pig Latin scripts to calcite plans.
* Implementation for MATCH_RECOGNIZE and its basic features.
* Support for correlated ANY/SOME/ALL subqueries.
* New join algorithm implementations.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4420139600bb68f8568c4b1c960ad4dbcb1a43f1
Its hash is 4420139600bb68f8568c4b1c960ad4dbcb1a43f1.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc0/
The hashes of the artifacts are as follows:
src.tar.gz.sha256
f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1066
Release artifacts are signed with the following key:
http://home.apache.org/~zabetak/zabetak.asc
https://people.apache.org/keys/committer/zabetak.asc (in the next LDAP
refresh)
Please vote on releasing this package as Apache Calcite 1.21.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.21.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Stamatis
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Danny Chan <yu...@gmail.com>.
> I removed the "[hotfix]" and "[doc]" tags from the commit messages. I
> don't think we need to create our own "tag language" in commit
> messages.
I agree, thanks.
Best,
Danny Chan
在 2019年9月6日 +0800 PM12:55，dev@calcite.apache.org，写道：
>
> I removed the "[hotfix]" and "[doc]" tags from the commit messages. I
> don't think we need to create our own "tag language" in commit
> messages.
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Darn it. I had already started on this, and put in a couple of hours
of work cleaning things up.
I've pushed my changes anyway, to my branch
https://github.com/julianhyde/calcite/tree/branch-1.21. I also made
some copy edits to the release notes. Stamatis can cherry-pick it all
into the official branch-1.21 for the next release candidate, and if
necessary reset the master branch.
I removed the "[hotfix]" and "[doc]" tags from the commit messages. I
don't think we need to create our own "tag language" in commit
messages.
On Thu, Sep 5, 2019 at 7:03 PM Danny Chan <yu...@gmail.com> wrote:
>
> Julian, I have merged these PRs.
>
> https://github.com/apache/calcite/pull/1435: merged
> https://github.com/apache/calcite/pull/1438: merged and mark fixed at version 1.21
> https://github.com/apache/calcite/pull/1431: merged
>
> Best,
> Danny Chan
> 在 2019年9月6日 +0800 AM4:35，dev@calcite.apache.org，写道：
> >
> > https://github.com/apache/calcite/pull/1435 <https://github.com/apache/calcite/pull/1435>
> > https://github.com/apache/calcite/pull/1438 <https://github.com/apache/calcite/pull/1438>
> > https://github.com/apache/calcite/pull/1439 <https://github.com/apache/calcite/pull/1439>
> > https://github.com/apache/calcite/pull/1431 <https://github.com/apache/calcite/pull/1431>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Danny Chan <yu...@gmail.com>.
Julian, I have merged these PRs.
https://github.com/apache/calcite/pull/1435: merged
https://github.com/apache/calcite/pull/1438: merged and mark fixed at version 1.21
https://github.com/apache/calcite/pull/1431: merged
Best,
Danny Chan
在 2019年9月6日 +0800 AM4:35，dev@calcite.apache.org，写道：
>
> https://github.com/apache/calcite/pull/1435 <https://github.com/apache/calcite/pull/1435>
> https://github.com/apache/calcite/pull/1438 <https://github.com/apache/calcite/pull/1438>
> https://github.com/apache/calcite/pull/1439 <https://github.com/apache/calcite/pull/1439>
> https://github.com/apache/calcite/pull/1431 <https://github.com/apache/calcite/pull/1431>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Despite the cancelation, I carried on my diligence.
-0 (binding) due to the spurious .xml.xxx files.
Everything else was OK: I checked checked hashes, README, NOTICE, LICENSE, built and tested on JDK 11/Ubuntu, ran RAT.
If there is another release, I would like to include some low-impact PRs. I will merge these to master if Stamatis, as RM, approves.
https://github.com/apache/calcite/pull/1435 <https://github.com/apache/calcite/pull/1435>
https://github.com/apache/calcite/pull/1438 <https://github.com/apache/calcite/pull/1438>
https://github.com/apache/calcite/pull/1439 <https://github.com/apache/calcite/pull/1439>
https://github.com/apache/calcite/pull/1431 <https://github.com/apache/calcite/pull/1431>
Also disable the test failure due to https://issues.apache.org/jira/browse/CALCITE-2816 <https://issues.apache.org/jira/browse/CALCITE-2816>.
Stamatis, can you please send a formal “[CANCEL]” email.
Julian
> On Sep 5, 2019, at 12:35 AM, Stamatis Zampetakis <za...@gmail.com> wrote:
>
> The vote for apache-calcite-1.21.0 release candidate 0, is cancelled due to
> redundant/unwanted files (pom.xml.next, pom.xml.tag) in the binaries.
>
> On Thu, Sep 5, 2019 at 8:04 AM Danny Chan <yu...@gmail.com> wrote:
>
>> I made the diff cmd and also see these outputs, it seems that pom.xml.next
>> and pom.xml.tag comes from a plugin ?
>>
>> Best,
>> Danny Chan
>> 在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
>>> I’m still reviewing the release, but I have an observation and a
>> question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve
>> not seen before. What is the purpose of these?
>>>
>>> It’s OK that we include DEPENDENCIES (which is generated). I’m a bit
>> surprised that we do not include .gitignore in the release.
>>>
>>> Julian
>>>
>>>
>>> $ cd /tmp
>>> $ tar xvfz
>> ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
>>> $ cd ~/dev/calcite
>>> $ git checkout calcite-1.21.0
>>> $ diff -r . /tmp/apache-calcite-1.21.0-src/
>>> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
>>> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
>>> Only in .: .git
>>> Only in .: .gitattributes
>>> Only in .: .gitignore
>>> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
>>> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
>>> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
>>>
>>>
>>>> On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com>
>> wrote:
>>>>
>>>> Hello,
>>>>
>>>> Let me join the vote as far as my Calcite-base project
>>>> https://www.zoomdata.com/ has an extensive test suite that was able to
>>>> detect two major issues (CALCITE-3145, CALCITE-3162) in the previous
>> 1.20
>>>> release (unfortunately, after the Calcite release itself during a
>>>> migration).
>>>>
>>>>
>>>> So here are Calcite 1.21.0 testing results:
>>>>
>>>> Local Calcite build with tests enabled on Linux: OK
>>>>
>>>> Calcite-based system test suite: OK
>>>>
>>>>
>>>> +1 (non-binding)
>>>>
>>>> On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
>>>>
>>>>> Regarding the 'ps' failures. I've added a suggestion to
>>>>>
>>>>>
>> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
>>>>> .
>>>>> Let's continue conversation there. Release threads are not a place
>> for
>>>>> technical discussion.
>>>>>
>>>>> On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
>>>>> <j....@pragmaticminds.de> wrote:
>>>>>>
>>>>>> Thanks Vladimir,
>>>>>>
>>>>>> This would also be my first assumption that its due to German
>> locale
>>>>> which also causes problems with parsing frequently.
>>>>>>
>>>>>> I think we should either fix that or note it somewhere in the how
>> to to
>>>>> ensure that people can reproduce the build, so I think I should keep
>> my -1
>>>>> (but it's not binding so not that big of an issue).
>>>>>>
>>>>>> Julian
>>>>>>
>>>>>> Von meinem Mobiltelefon gesendet
>>>>>>
>>>>>>
>>>>>> -------- Ursprüngliche Nachricht --------
>>>>>> Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release
>> candidate 0)
>>>>>> Von: Vladimir Sitnikov
>>>>>> An: Apache Calcite dev list
>>>>>> Cc:
>>>>>>
>>>>>> It is a "well known"
>>>>>> https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
>>>>>> fails in Russian locale
>>>>>>
>>>>>> In other words, "float number parsing is locale-sensitive".
>>>>>> Vladimir
>>>>>
>>>>
>>>>
>>>> --
>>>> Best regards,
>>>> Anton.
>>>
>>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Stamatis Zampetakis <za...@gmail.com>.
The vote for apache-calcite-1.21.0 release candidate 0, is cancelled due to
redundant/unwanted files (pom.xml.next, pom.xml.tag) in the binaries.
On Thu, Sep 5, 2019 at 8:04 AM Danny Chan <yu...@gmail.com> wrote:
> I made the diff cmd and also see these outputs, it seems that pom.xml.next
> and pom.xml.tag comes from a plugin ?
>
> Best,
> Danny Chan
> 在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> > I’m still reviewing the release, but I have an observation and a
> question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve
> not seen before. What is the purpose of these?
> >
> > It’s OK that we include DEPENDENCIES (which is generated). I’m a bit
> surprised that we do not include .gitignore in the release.
> >
> > Julian
> >
> >
> > $ cd /tmp
> > $ tar xvfz
> ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> > $ cd ~/dev/calcite
> > $ git checkout calcite-1.21.0
> > $ diff -r . /tmp/apache-calcite-1.21.0-src/
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> > Only in .: .git
> > Only in .: .gitattributes
> > Only in .: .gitignore
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> > Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
> >
> >
> > > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com>
> wrote:
> > >
> > > Hello,
> > >
> > > Let me join the vote as far as my Calcite-base project
> > > https://www.zoomdata.com/ has an extensive test suite that was able to
> > > detect two major issues (CALCITE-3145, CALCITE-3162) in the previous
> 1.20
> > > release (unfortunately, after the Calcite release itself during a
> > > migration).
> > >
> > >
> > > So here are Calcite 1.21.0 testing results:
> > >
> > > Local Calcite build with tests enabled on Linux: OK
> > >
> > > Calcite-based system test suite: OK
> > >
> > >
> > > +1 (non-binding)
> > >
> > > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
> > >
> > > > Regarding the 'ps' failures. I've added a suggestion to
> > > >
> > > >
> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > > .
> > > > Let's continue conversation there. Release threads are not a place
> for
> > > > technical discussion.
> > > >
> > > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > > <j....@pragmaticminds.de> wrote:
> > > > >
> > > > > Thanks Vladimir,
> > > > >
> > > > > This would also be my first assumption that its due to German
> locale
> > > > which also causes problems with parsing frequently.
> > > > >
> > > > > I think we should either fix that or note it somewhere in the how
> to to
> > > > ensure that people can reproduce the build, so I think I should keep
> my -1
> > > > (but it's not binding so not that big of an issue).
> > > > >
> > > > > Julian
> > > > >
> > > > > Von meinem Mobiltelefon gesendet
> > > > >
> > > > >
> > > > > -------- Ursprüngliche Nachricht --------
> > > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release
> candidate 0)
> > > > > Von: Vladimir Sitnikov
> > > > > An: Apache Calcite dev list
> > > > > Cc:
> > > > >
> > > > > It is a "well known"
> > > > > https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
> > > > > fails in Russian locale
> > > > >
> > > > > In other words, "float number parsing is locale-sensitive".
> > > > > Vladimir
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Anton.
> >
>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Danny Chan <yu...@gmail.com>.
I made the diff cmd and also see these outputs, it seems that pom.xml.next and pom.xml.tag comes from a plugin ?
Best,
Danny Chan
在 2019年9月5日 +0800 AM2:53，Julian Hyde <jh...@apache.org>，写道：
> I’m still reviewing the release, but I have an observation and a question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve not seen before. What is the purpose of these?
>
> It’s OK that we include DEPENDENCIES (which is generated). I’m a bit surprised that we do not include .gitignore in the release.
>
> Julian
>
>
> $ cd /tmp
> $ tar xvfz ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
> $ cd ~/dev/calcite
> $ git checkout calcite-1.21.0
> $ diff -r . /tmp/apache-calcite-1.21.0-src/
> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
> Only in .: .git
> Only in .: .gitattributes
> Only in .: .gitignore
> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
> Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
>
>
> > On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com> wrote:
> >
> > Hello,
> >
> > Let me join the vote as far as my Calcite-base project
> > https://www.zoomdata.com/ has an extensive test suite that was able to
> > detect two major issues (CALCITE-3145, CALCITE-3162) in the previous 1.20
> > release (unfortunately, after the Calcite release itself during a
> > migration).
> >
> >
> > So here are Calcite 1.21.0 testing results:
> >
> > Local Calcite build with tests enabled on Linux: OK
> >
> > Calcite-based system test suite: OK
> >
> >
> > +1 (non-binding)
> >
> > On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
> >
> > > Regarding the 'ps' failures. I've added a suggestion to
> > >
> > > https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> > > .
> > > Let's continue conversation there. Release threads are not a place for
> > > technical discussion.
> > >
> > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> > > <j....@pragmaticminds.de> wrote:
> > > >
> > > > Thanks Vladimir,
> > > >
> > > > This would also be my first assumption that its due to German locale
> > > which also causes problems with parsing frequently.
> > > >
> > > > I think we should either fix that or note it somewhere in the how to to
> > > ensure that people can reproduce the build, so I think I should keep my -1
> > > (but it's not binding so not that big of an issue).
> > > >
> > > > Julian
> > > >
> > > > Von meinem Mobiltelefon gesendet
> > > >
> > > >
> > > > -------- Ursprüngliche Nachricht --------
> > > > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
> > > > Von: Vladimir Sitnikov
> > > > An: Apache Calcite dev list
> > > > Cc:
> > > >
> > > > It is a "well known"
> > > > https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
> > > > fails in Russian locale
> > > >
> > > > In other words, "float number parsing is locale-sensitive".
> > > > Vladimir
> > >
> >
> >
> > --
> > Best regards,
> > Anton.
>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
I’m still reviewing the release, but I have an observation and a question. There are a bunch of pom.xml.next and pom.xml.tag files that I’ve not seen before. What is the purpose of these?
It’s OK that we include DEPENDENCIES (which is generated). I’m a bit surprised that we do not include .gitignore in the release.
Julian
$ cd /tmp
$ tar xvfz ~/apache/dist/dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz
$ cd ~/dev/calcite
$ git checkout calcite-1.21.0
$ diff -r . /tmp/apache-calcite-1.21.0-src/
Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/babel: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/cassandra: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/core: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/: DEPENDENCIES
Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/druid: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/elasticsearch: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/example/csv: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/example/function: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/example: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/file: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/geode: pom.xml.tag
Only in .: .git
Only in .: .gitattributes
Only in .: .gitignore
Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/kafka: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/linq4j: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/mongodb: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/pig: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/piglet: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/plus: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/server: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/spark: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/splunk: pom.xml.tag
Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.next
Only in /tmp/apache-calcite-1.21.0-src/ubenchmark: pom.xml.tag
> On Sep 4, 2019, at 8:23 AM, Anton Haidai <an...@gmail.com> wrote:
>
> Hello,
>
> Let me join the vote as far as my Calcite-base project
> https://www.zoomdata.com/ has an extensive test suite that was able to
> detect two major issues (CALCITE-3145, CALCITE-3162) in the previous 1.20
> release (unfortunately, after the Calcite release itself during a
> migration).
>
>
> So here are Calcite 1.21.0 testing results:
>
> Local Calcite build with tests enabled on Linux: OK
>
> Calcite-based system test suite: OK
>
>
> +1 (non-binding)
>
> On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
>
>> Regarding the 'ps' failures. I've added a suggestion to
>>
>> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
>> .
>> Let's continue conversation there. Release threads are not a place for
>> technical discussion.
>>
>> On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
>> <j....@pragmaticminds.de> wrote:
>>>
>>> Thanks Vladimir,
>>>
>>> This would also be my first assumption that its due to German locale
>> which also causes problems with parsing frequently.
>>>
>>> I think we should either fix that or note it somewhere in the how to to
>> ensure that people can reproduce the build, so I think I should keep my -1
>> (but it's not binding so not that big of an issue).
>>>
>>> Julian
>>>
>>> Von meinem Mobiltelefon gesendet
>>>
>>>
>>> -------- Ursprüngliche Nachricht --------
>>> Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
>>> Von: Vladimir Sitnikov
>>> An: Apache Calcite dev list
>>> Cc:
>>>
>>> It is a "well known"
>>> https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
>>> fails in Russian locale
>>>
>>> In other words, "float number parsing is locale-sensitive".
>>> Vladimir
>>
>
>
> --
> Best regards,
> Anton.
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Anton Haidai <an...@gmail.com>.
Hello,
Let me join the vote as far as my Calcite-base project
https://www.zoomdata.com/ has an extensive test suite that was able to
detect two major issues (CALCITE-3145, CALCITE-3162) in the previous 1.20
release (unfortunately, after the Calcite release itself during a
migration).
So here are Calcite 1.21.0 testing results:
Local Calcite build with tests enabled on Linux: OK
Calcite-based system test suite: OK
+1 (non-binding)
On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde <jh...@apache.org> wrote:
> Regarding the 'ps' failures. I've added a suggestion to
>
> https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772
> .
> Let's continue conversation there. Release threads are not a place for
> technical discussion.
>
> On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
> <j....@pragmaticminds.de> wrote:
> >
> > Thanks Vladimir,
> >
> > This would also be my first assumption that its due to German locale
> which also causes problems with parsing frequently.
> >
> > I think we should either fix that or note it somewhere in the how to to
> ensure that people can reproduce the build, so I think I should keep my -1
> (but it's not binding so not that big of an issue).
> >
> > Julian
> >
> > Von meinem Mobiltelefon gesendet
> >
> >
> > -------- Ursprüngliche Nachricht --------
> > Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
> > Von: Vladimir Sitnikov
> > An: Apache Calcite dev list
> > Cc:
> >
> > It is a "well known"
> > https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
> > fails in Russian locale
> >
> > In other words, "float number parsing is locale-sensitive".
> > Vladimir
>
--
Best regards,
Anton.
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Regarding the 'ps' failures. I've added a suggestion to
https://issues.apache.org/jira/browse/CALCITE-2816?focusedCommentId=16921772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16921772.
Let's continue conversation there. Release threads are not a place for
technical discussion.
On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer
<j....@pragmaticminds.de> wrote:
>
> Thanks Vladimir,
>
> This would also be my first assumption that its due to German locale which also causes problems with parsing frequently.
>
> I think we should either fix that or note it somewhere in the how to to ensure that people can reproduce the build, so I think I should keep my -1 (but it's not binding so not that big of an issue).
>
> Julian
>
> Von meinem Mobiltelefon gesendet
>
>
> -------- Ursprüngliche Nachricht --------
> Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
> Von: Vladimir Sitnikov
> An: Apache Calcite dev list
> Cc:
>
> It is a "well known"
> https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
> fails in Russian locale
>
> In other words, "float number parsing is locale-sensitive".
> Vladimir
AW: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Thanks Vladimir,
This would also be my first assumption that its due to German locale which also causes problems with parsing frequently.
I think we should either fix that or note it somewhere in the how to to ensure that people can reproduce the build, so I think I should keep my -1 (but it's not binding so not that big of an issue).
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Von: Vladimir Sitnikov
An: Apache Calcite dev list
Cc:
It is a "well known"
https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
fails in Russian locale
In other words, "float number parsing is locale-sensitive".
Vladimir
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Vladimir Sitnikov <si...@gmail.com>.
It is a "well known"
https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction
fails in Russian locale
In other words, "float number parsing is locale-sensitive".
Vladimir
AW: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Stamatis,
Yes, if it works for you then I'll try to track that down and file a Jira.
Julian
Von meinem Mobiltelefon gesendet
-------- Ursprüngliche Nachricht --------
Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Von: Stamatis Zampetakis
An: dev@calcite.apache.org
Cc:
Thanks for raising this Julian.
I tested today on MacOS Mojave (10.14.5) and jdk 1.8.0_111 and build (mvnw
install) finishes without errors.
I guess the problem you raised is related to your local environment.
Can you please log a JIRA with more details on what happens?
Can you also check if this is a regression from 1.20.0?
Best,
Stamatis
On Mon, Sep 2, 2019, 9:32 PM Julian Feinauer <j....@pragmaticminds.de>
wrote:
> Hi Stamatis,
>
> thank you for your effort!
>
> Unfortunately, I think I have to vote
>
> -1 (non-binding)
>
> as I encountered an issue building the artefacts with the given
> instruction (see below).
> But as my vote is non-binding it's up to the more experienced devs to
> decide how to handle this case exactly.
> I am not sure on how to interpret the policy [1] in that case.
>
> I also found some minor issues I described below.
>
> I checked:
> - Checksum and Signature correct
> - Checked LICENSE and NOTICE
> - Run build as described in "howto.md" (mvnw install) on "java version
> "1.8.0_181" (Hotspot) on OS X fails (see below)
> - Run build as "mvnw install -DskipTests" succeeds
> - Checked no unexpected binaries
>
> Issues:
> - I am unable to build the package (see above) as the following tests fail:
>
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while
> parsing value [0...
> [ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL
> "select disti...
> [INFO]
> [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24
>
> Minor Issues:
> - README is not up to date as it says that README.md contains "examples of
> running calcite" which it doesn’t
> - Information on how to build the project is only available on the
> homepage not in one of the readmes or doc files (a link to "howto.md" in
> the README or README.md would be good, I think)
>
> Best
> Julian
>
> [1] https://apache.org/legal/release-policy.html
>
> Am 02.09.19, 17:16 schrieb "Stamatis Zampetakis" <za...@gmail.com>:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.21.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> This release comes two months after 1.20.0 and brings many bug fixes
> and
> new
> important features among others the following.
>
> * Support for implicit casts.
> * Transformation of Pig Latin scripts to calcite plans.
> * Implementation for MATCH_RECOGNIZE and its basic features.
> * Support for correlated ANY/SOME/ALL subqueries.
> * New join algorithm implementations.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4420139600bb68f8568c4b1c960ad4dbcb1a43f1
>
> Its hash is 4420139600bb68f8568c4b1c960ad4dbcb1a43f1.
>
> The artifacts to be voted on are located here:
>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1066
>
> Release artifacts are signed with the following key:
> http://home.apache.org/~zabetak/zabetak.asc
> https://people.apache.org/keys/committer/zabetak.asc (in the next LDAP
> refresh)
>
> Please vote on releasing this package as Apache Calcite 1.21.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.21.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Stamatis
>
>
>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Stamatis Zampetakis <za...@gmail.com>.
Thanks for raising this Julian.
I tested today on MacOS Mojave (10.14.5) and jdk 1.8.0_111 and build (mvnw
install) finishes without errors.
I guess the problem you raised is related to your local environment.
Can you please log a JIRA with more details on what happens?
Can you also check if this is a regression from 1.20.0?
Best,
Stamatis
On Mon, Sep 2, 2019, 9:32 PM Julian Feinauer <j....@pragmaticminds.de>
wrote:
> Hi Stamatis,
>
> thank you for your effort!
>
> Unfortunately, I think I have to vote
>
> -1 (non-binding)
>
> as I encountered an issue building the artefacts with the given
> instruction (see below).
> But as my vote is non-binding it's up to the more experienced devs to
> decide how to handle this case exactly.
> I am not sure on how to interpret the policy [1] in that case.
>
> I also found some minor issues I described below.
>
> I checked:
> - Checksum and Signature correct
> - Checked LICENSE and NOTICE
> - Run build as described in "howto.md" (mvnw install) on "java version
> "1.8.0_181" (Hotspot) on OS X fails (see below)
> - Run build as "mvnw install -DskipTests" succeeds
> - Checked no unexpected binaries
>
> Issues:
> - I am unable to build the package (see above) as the following tests fail:
>
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while
> parsing value [0...
> [ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL
> "select disti...
> [INFO]
> [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24
>
> Minor Issues:
> - README is not up to date as it says that README.md contains "examples of
> running calcite" which it doesn’t
> - Information on how to build the project is only available on the
> homepage not in one of the readmes or doc files (a link to "howto.md" in
> the README or README.md would be good, I think)
>
> Best
> Julian
>
> [1] https://apache.org/legal/release-policy.html
>
> Am 02.09.19, 17:16 schrieb "Stamatis Zampetakis" <za...@gmail.com>:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.21.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> This release comes two months after 1.20.0 and brings many bug fixes
> and
> new
> important features among others the following.
>
> * Support for implicit casts.
> * Transformation of Pig Latin scripts to calcite plans.
> * Implementation for MATCH_RECOGNIZE and its basic features.
> * Support for correlated ANY/SOME/ALL subqueries.
> * New join algorithm implementations.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4420139600bb68f8568c4b1c960ad4dbcb1a43f1
>
> Its hash is 4420139600bb68f8568c4b1c960ad4dbcb1a43f1.
>
> The artifacts to be voted on are located here:
>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc0/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1066
>
> Release artifacts are signed with the following key:
> http://home.apache.org/~zabetak/zabetak.asc
> https://people.apache.org/keys/committer/zabetak.asc (in the next LDAP
> refresh)
>
> Please vote on releasing this package as Apache Calcite 1.21.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.21.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Stamatis
>
>
>
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Stamatis,
thank you for your effort!
Unfortunately, I think I have to vote
-1 (non-binding)
as I encountered an issue building the artefacts with the given instruction (see below).
But as my vote is non-binding it's up to the more experienced devs to decide how to handle this case exactly.
I am not sure on how to interpret the policy [1] in that case.
I also found some minor issues I described below.
I checked:
- Checksum and Signature correct
- Checked LICENSE and NOTICE
- Run build as described in "howto.md" (mvnw install) on "java version "1.8.0_181" (Hotspot) on OS X fails (see below)
- Run build as "mvnw install -DskipTests" succeeds
- Checked no unexpected binaries
Issues:
- I am unable to build the package (see above) as the following tests fail:
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while parsing value [0...
[ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL "select disti...
[INFO]
[ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24
Minor Issues:
- README is not up to date as it says that README.md contains "examples of running calcite" which it doesn’t
- Information on how to build the project is only available on the homepage not in one of the readmes or doc files (a link to "howto.md" in the README or README.md would be good, I think)
Best
Julian
[1] https://apache.org/legal/release-policy.html
Am 02.09.19, 17:16 schrieb "Stamatis Zampetakis" <za...@gmail.com>:
Hi all,
I have created a build for Apache Calcite 1.21.0, release candidate 0.
Thanks to everyone who has contributed to this release.
This release comes two months after 1.20.0 and brings many bug fixes and
new
important features among others the following.
* Support for implicit casts.
* Transformation of Pig Latin scripts to calcite plans.
* Implementation for MATCH_RECOGNIZE and its basic features.
* Support for correlated ANY/SOME/ALL subqueries.
* New join algorithm implementations.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4420139600bb68f8568c4b1c960ad4dbcb1a43f1
Its hash is 4420139600bb68f8568c4b1c960ad4dbcb1a43f1.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc0/
The hashes of the artifacts are as follows:
src.tar.gz.sha256
f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f33334e
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1066
Release artifacts are signed with the following key:
http://home.apache.org/~zabetak/zabetak.asc
https://people.apache.org/keys/committer/zabetak.asc (in the next LDAP
refresh)
Please vote on releasing this package as Apache Calcite 1.21.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.21.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Stamatis
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)
Posted by Danny Chan <yu...@gmail.com>.
Thanks, Stamatis, here are the things I have checked:
• The commit hash code correct
• The src package sha256 code correct
• Checked LICENSE and NOTICE
• Checked no unexpected binaries
I didn’t encounter the problem of Julian Feinauer, so I’m + 1 for the release.
Best,
Danny Chan
在 2019年9月2日 +0800 PM11:16，dev@calcite.apache.org，写道：
>
> I checked:
> - Checksum and Signature correct
> - Checked LICENSE and NOTICE
> - Run build as described in "howto.md" (mvnw install) on "java version "1.8.0_181" (Hotspot) on OS X fails (see below)
> - Run build as "mvnw install -DskipTests" succeeds
> - Checked no unexpected binaries