You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/28 09:06:49 UTC

[GitHub] [pulsar] congbobo184 opened a new pull request, #17317: [fix][client] Fix reach redeliverCount client can't send batch messag…

congbobo184 opened a new pull request, #17317:
URL: https://github.com/apache/pulsar/pull/17317

   issue:  link https://github.com/apache/pulsar/pull/17287, don't fix the batch message to DLQ
   ### Motivation
   can make batch messages to DLQ when reaching the redelivery count
   ### Modification
   ```
   redeliveryCount > deadLetterPolicy.getMaxRedeliverCount()
   ```
    send this message to DLQ directly
   ### Verifying this change
   add the test
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   
   - [x] `doc-not-needed`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #17317: [fix][client] Fix reach redeliverCount client can't send batch messags

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17317:
URL: https://github.com/apache/pulsar/pull/17317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #17317: [fix][client] Fix reach redeliverCount client can't send batch messag…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17317:
URL: https://github.com/apache/pulsar/pull/17317#issuecomment-1229412198

   @congbobo184 Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org