You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/09/07 23:56:12 UTC

Change in asterixdb[master]: [ASTERIXDB-2895][RT] Vsize buffers in PyUDF IPC

From Ian Maxon <im...@uci.edu>:

Hello Dmitry Lychagin, Till Westmann, Jenkins, Michael Blow, Anon. E. Moose #1000171, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643

to look at the new patch set (#14).

Change subject: [ASTERIXDB-2895][RT] Vsize buffers in PyUDF IPC
......................................................................

[ASTERIXDB-2895][RT] Vsize buffers in PyUDF IPC

- user mode changes: no
- storage format changes: no
- interface changes: no

Details:
- Convert most uses of ByteBuffer to ArrayBackedValueStorage
  so that the size of the buffer can grow arbitrarily with
  the data
- Convert all serialization interfaces that used ByteBuffer
  to use DataOutput instead
- Fix UTF8 encoding bugs by using StdToModUTF8DataOutput
- Adapt some of the UTF8 printing code to be used for
  UTF8 output to msgpack

Change-Id: Ic95e592b42139b4750af8bb20291f926b3c973e2
---
M asterixdb/asterix-app/src/main/resources/entrypoint.py
M asterixdb/asterix-app/src/test/resources/cc.conf
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/python_open_type_validation/type_validation.11.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/python_open_type_validation/type_validation.2.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/mysentiment_twitter/mysentiment_twitter.13.adm
A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/builders/StdToModUTF8DataOutputFactory.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonMessageBuilder.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalScalarPythonFunctionEvaluator.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/PythonLibraryEvaluator.java
A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessagePackUtils.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessagePackerFromADM.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/msgpack/MessageUnpackerToADM.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
15 files changed, 607 insertions(+), 447 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/12643/14
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic95e592b42139b4750af8bb20291f926b3c973e2
Gerrit-Change-Number: 12643
Gerrit-PatchSet: 14
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-MessageType: newpatchset