You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/20 15:57:00 UTC
[jira] [Commented] (SAMZA-1366) ScriptRunner should allow callers
to control the child process environment.
[ https://issues.apache.org/jira/browse/SAMZA-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094872#comment-16094872 ]
ASF GitHub Bot commented on SAMZA-1366:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/245
SAMZA-1366: ScriptRunner should allow callers to control the child pr…
…ocess environment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza script-runner-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit 6cf0c019469b58726df7b718201d49de108ffbeb
Author: Jacob Maes <jm...@linkedin.com>
Date: 2017-07-20T15:53:56Z
SAMZA-1366: ScriptRunner should allow callers to control the child process environment.
----
> ScriptRunner should allow callers to control the child process environment.
> ---------------------------------------------------------------------------
>
> Key: SAMZA-1366
> URL: https://issues.apache.org/jira/browse/SAMZA-1366
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
> Fix For: 0.14.0
>
>
> The ScriptRunner class used by samza-rest currently uses the defaults for ProcessBuilder to construct the child process and by default, all environment variables are forwarded to the child process.
> This causes problems with log settings (e.g. console vs file), class path, config collisions, etc.
> The goals of this ticket are:
> 1. Allow the caller to dictate whether to forward the environment variables or start with a clean slate.
> 2. Allow the caller to explicitly specify environment variables to add to the child environment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)