You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Alexander Murmann <am...@pivotal.io> on 2017/07/13 17:42:12 UTC
Re: Review Request 60523: GEODE-3141 New flow: GetRegion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review180447
-----------------------------------------------------------
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
Lines 46 (patched)
<https://reviews.apache.org/r/60523/#comment255630>
weren't we getting rid of these?
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
Line 104 (original), 89 (patched)
<https://reviews.apache.org/r/60523/#comment255631>
How do you feel about splitting the different test cases into different test examples? That way we get more information even on a failed run and it's easier to see what cases exist.
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
Lines 92 (patched)
<https://reviews.apache.org/r/60523/#comment255632>
could this be more elegantly expressed by checking membership in a list of test regions? Would be a little more DRY and might read better.
- Alexander Murmann
On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 11:06 p.m.)
>
>
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Brian Rowe.
>
>
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added a GetRegion(regionName) API. More details about the server region can be added if needed. This implementation just has a success flag and flag saying whether the region is destroyed.
>
>
> Diffs
> -----
>
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java 4318fb444dd0eb5f5d07175a466e26f03933cc4d
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java 4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java PRE-CREATION
> geode-protobuf/src/main/proto/clientProtocol.proto 0c192950a4e750f7c55e186c18a79a6c52716bf0
> geode-protobuf/src/main/proto/region_API.proto d3af17acb1ee45c134837c321b2009c8532817cc
> geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java dc897241fc229da53a5ff7a0e2df1678b8bceb6d
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java 77b984f7e28a7bfa21b8e1c8c6a83467e9a37242
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java e8f1e651a71240474a793d005164df1ba5d4cda7
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60523/diff/1/
>
>
> Testing
> -------
>
> new unit tests
>
>
> Thanks,
>
> Bruce Schuchardt
>
>