You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by srikanteswartalluri <gi...@git.apache.org> on 2015/11/25 19:43:00 UTC
[GitHub] cloudstack pull request: Change references to people.apache.org to...
GitHub user srikanteswartalluri opened a pull request:
https://github.com/apache/cloudstack/pull/1123
Change references to people.apache.org to home.apache.org in the test…
… code
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srikanteswartalluri/cloudstack peopleapache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1123
----
commit 759ab5f1c12338e0738251660f3a2778229eb30f
Author: SrikanteswaraRao Talluri <ta...@apache.org>
Date: 2015-11-25T18:37:43Z
Change references to people.apache.org to home.apache.org in the test code
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Change references to people.apache.org to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Change references to people.apache.org to...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1123#issuecomment-159816344
@srikanteswartalluri
1. no direct commits to master please..
2. as per the review process, wait for two lgtms before doing a merge (and use the git pr script)
3. this is relevant for 4.6 branch ( and 4.5) so, PR should be for 4.6 and merged forward .
Please revert the direct commit and reopen the PR for 4.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Change references to people.apache.org to...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1123#issuecomment-159807931
Thanks Talluri for quickly acting on it. I checked the urls and all are reachable.
LGTM !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Change references to people.apache.org to...
Posted by srikanteswartalluri <gi...@git.apache.org>.
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/1123#issuecomment-159821904
@karuturi
Reverted the commit on master and 4.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---