You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/11/22 03:13:35 UTC
Review Request 28367: Fix deadlock between SocketManager::send() and
internal::send().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28367/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
This was a deadlock between the this and processes locks that occured because the .then() on socket futures can be invoked immediately with the new implementation of poll.
This fixes the issue in Metrics.Snapshot you might have seen.
Diffs
-----
3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
Diff: https://reviews.apache.org/r/28367/diff/
Testing
-------
make check
Thanks,
Joris Van Remoortere
Re: Review Request 28367: Fix deadlock between SocketManager::send()
and internal::send().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28367/#review62821
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 22, 2014, 2:13 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28367/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 2:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This was a deadlock between the this and processes locks that occured because the .then() on socket futures can be invoked immediately with the new implementation of poll.
> This fixes the issue in Metrics.Snapshot you might have seen.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
>
> Diff: https://reviews.apache.org/r/28367/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28367: Fix deadlock between SocketManager::send()
and internal::send().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28367/#review62723
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28367]
All tests passed.
- Mesos ReviewBot
On Nov. 22, 2014, 2:13 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28367/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 2:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This was a deadlock between the this and processes locks that occured because the .then() on socket futures can be invoked immediately with the new implementation of poll.
> This fixes the issue in Metrics.Snapshot you might have seen.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
>
> Diff: https://reviews.apache.org/r/28367/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>