You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/28 09:30:10 UTC
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #26: Make use
of server timezone API when possible
kezhenxu94 opened a new pull request #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26
resolves https://github.com/apache/skywalking/issues/4044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request
#26: Make use of server timezone API when possible
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#discussion_r361793327
##########
File path: commands/interceptor/duration.go
##########
@@ -66,11 +68,20 @@ func DurationInterceptor(ctx *cli.Context) error {
// NOTE that when either(both) `start` or `end` is(are) given, there is no timezone info
// in the format, (e.g. 2019-11-09 1001), so they'll be considered as UTC-based,
Review comment:
The comments need to change based on the new logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #26: Make use
of server timezone API when possible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#issuecomment-569401707
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=h1) Report
> Merging [#26](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/5d2b49dd9ed46a415daf53d40a5c3b3af0c36c80?src=pr&el=desc) will **decrease** coverage by `9.15%`.
> The diff coverage is `11.76%`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 64.7% 55.55% -9.16%
==========================================
Files 5 6 +1
Lines 85 99 +14
==========================================
Hits 55 55
- Misses 24 37 +13
- Partials 6 7 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0% <0%> (ø)` | |
| [commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `50.98% <25%> (-5.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=footer). Last update [5d2b49d...d738856](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #26: Make use
of server timezone API when possible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#issuecomment-569401707
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=h1) Report
> Merging [#26](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/5d2b49dd9ed46a415daf53d40a5c3b3af0c36c80?src=pr&el=desc) will **decrease** coverage by `10.25%`.
> The diff coverage is `10.52%`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #26 +/- ##
===========================================
- Coverage 64.7% 54.45% -10.26%
===========================================
Files 5 6 +1
Lines 85 101 +16
===========================================
Hits 55 55
- Misses 24 39 +15
- Partials 6 7 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0% <0%> (ø)` | |
| [commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `50.98% <25%> (-5.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=footer). Last update [5d2b49d...a11773a](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng merged pull request #26: Make use of
server timezone API when possible
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #26: Make use
of server timezone API when possible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#issuecomment-569401707
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=h1) Report
> Merging [#26](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/5d2b49dd9ed46a415daf53d40a5c3b3af0c36c80?src=pr&el=desc) will **decrease** coverage by `9.15%`.
> The diff coverage is `11.76%`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 64.7% 55.55% -9.16%
==========================================
Files 5 6 +1
Lines 85 99 +14
==========================================
Hits 55 55
- Misses 24 37 +13
- Partials 6 7 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0% <0%> (ø)` | |
| [commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `50.98% <25%> (-5.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=footer). Last update [5d2b49d...f20a70c](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #26: Make use of
server timezone API when possible
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#issuecomment-569926719
> LGTM. We could consider adding e2e for CLI by using the latest release of SkyWalking docker image or binary tar.
Sounds good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io commented on issue #26: Make use of
server timezone API when possible
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#issuecomment-569401707
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=h1) Report
> Merging [#26](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/5d2b49dd9ed46a415daf53d40a5c3b3af0c36c80?src=pr&el=desc) will **decrease** coverage by `9.15%`.
> The diff coverage is `11.76%`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 64.7% 55.55% -9.16%
==========================================
Files 5 6 +1
Lines 85 99 +14
==========================================
Hits 55 55
- Misses 24 37 +13
- Partials 6 7 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0% <0%> (ø)` | |
| [commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/26/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `50.98% <25%> (-5.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=footer). Last update [5d2b49d...729821b](https://codecov.io/gh/apache/skywalking-cli/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services