You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/21 01:38:44 UTC

[GitHub] [calcite] danny0405 commented on issue #1523: [CALCITE-3432] RexBuilder construct method with the default of RelDataTypeFactory.

danny0405 commented on issue #1523: [CALCITE-3432] RexBuilder construct method with the default of RelDataTypeFactory.
URL: https://github.com/apache/calcite/pull/1523#issuecomment-544317113
 
 
   type factory is so important for the specific type system of all kinds of engines, almost every framework that uses Calcite would build their own type systems. So, i'm inclined to pass explicit type factory in the constructor. The `default` type factory is confusing, besides Calcite itself, i believe it would be rarely used for other engines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services