You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/02/04 18:16:36 UTC
[GitHub] incubator-brooklyn pull request: Forbid imports from com.google.ap...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/504
Forbid imports from com.google.api.client.repackaged
Prompted by #503 and bf38d7f7c27e51938e59d8e6ebc75fa7df889f37. We could also prohibit `com.google.api.client` entirely or `..client.util` additionally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #504
----
commit 8b44d76c6d5d64fa46da49eaf936943c2fd8d6fc
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-02-04T17:08:07Z
Forbid imports from com.google.api.client.repackaged
They're - currently - never intended and are confusing when you come to
list your bundle dependecies in a catalogue entry.
If we start using com.google.api.client... we can drop this check.
commit c857845acc97180dd7e0dd9faab8d3f427ca45cf
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-02-04T17:08:25Z
BindDnsServerByonLiveTest.testDns locationSpec argument is optional
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Forbid imports from com.google.ap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Forbid imports from com.google.ap...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/504#issuecomment-73034472
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---