You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/09 14:56:46 UTC
[GitHub] [incubator-nuttx] ptka opened a new pull request #5195: Pimoroni Tiny 2040 support
ptka opened a new pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195
## Summary
Added support for the Pimoroni Tiny 2040 device: boards/arm/rp2040/pimoroni-tiny2040
It’s an RP2040 based device with some interesting features:
+ small form factor (18x21.3mm)
+ 8 MByte Flash
+ RGB LED
+ Reset Button
+ USB-C
- reduced pin-header
The support in derived from: boards/arm/rp2040/raspberrypi-pico
## Impact
Only file changed outside of board configuration folder: boards/Kconfig
## Testing
All included configuration tested on real device.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781487558
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <stdint.h>
Review comment:
You have the same in boards/arm/rp2040/pimoroni-tiny2040/include/board.h from you PR.
In general if you expect header files to be included in assembly then having `stdint.h` will definitely bring you into troubles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1008401655
> Can I still squash the open PR or do I need to close it and open a new one?
Yes, you still can sqash and then use `git push -f origin branch_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781543921
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
##########
@@ -0,0 +1,75 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
Review comment:
Fixed :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1009295127
@pkarashchenko : PR updated and squashed with your suggestions. Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781492210
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
##########
@@ -0,0 +1,404 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <sys/types.h>
Review comment:
Let me check this, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781508323
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
##########
@@ -0,0 +1,178 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <nuttx/board.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+#include "arm_internal.h"
Review comment:
Includes removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781480622
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <stdint.h>
Review comment:
```suggestion
#ifndef __ASSEMBLY__
# include <stdint.h>
#endif
```
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
##########
@@ -0,0 +1,178 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <nuttx/board.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+#include "arm_internal.h"
Review comment:
Why do we need this include here?
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <stdint.h>
Review comment:
```suggestion
#ifndef __ASSEMBLY__
# include <stdint.h>
#endif
```
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
##########
@@ -0,0 +1,404 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <sys/types.h>
Review comment:
Maybe we can replace it with `stdint.h`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1008424977
Thanks ... I managed to get it squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1008368453
Can I still squash the open PR or do I need to close it and open a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781491376
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
##########
@@ -0,0 +1,178 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_boardinitialize.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <nuttx/board.h>
+#include <arch/board/board.h>
+
+#include "arm_arch.h"
+#include "arm_internal.h"
Review comment:
It's part of the original code, this device support is based on.
Nevertheless ... let me check, if I can remove these includes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781508569
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
##########
@@ -0,0 +1,404 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/src/rp2040_gpio.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <sys/types.h>
Review comment:
Include updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781485671
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2cdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2CDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <stdint.h>
Review comment:
Is this common practice in NuttX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#discussion_r781530725
##########
File path: boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
##########
@@ -0,0 +1,75 @@
+/****************************************************************************
+ * boards/arm/rp2040/pimoroni-tiny2040/include/rp2040_i2sdev.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+#define __BOARDS_ARM_RP2040_PIMORONI_TINY2040_INCLUDE_RP2040_I2SDEV_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
pkarashchenko edited a comment on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1008401655
> Can I still squash the open PR or do I need to close it and open a new one?
Yes, you still can sqash and then use `git push -f origin branch_name`. It will update existing PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5195: Pimoroni Tiny 2040 support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5195:
URL: https://github.com/apache/incubator-nuttx/pull/5195#issuecomment-1008346485
@ptka can you squash the patchset into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org