You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/02 19:12:27 UTC
[jira] [Commented] (COUCHDB-2829) Fauxton username and password do
not autofill
[ https://issues.apache.org/jira/browse/COUCHDB-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941420#comment-14941420 ]
ASF GitHub Bot commented on COUCHDB-2829:
-----------------------------------------
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/546
Fix for Safari not recognizing autofill on login form
Safari doesn't trigger change events for form field autofills,
so the state of the login component doesn't updated, triggering
the rather irritating "you didn't fill in all the fields" error
when visually you sure did.
Since existing polyfill options don't work (see ticket), this fix
explicitly checks for the condition of a mismatch of
username-password form values and component state. It's a little
inelegant, but justifiable I think.
Closes COUCHDB-2829
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton safari-login-autofill-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #546
----
commit 71764658aa1c6a195542f8103a6c363f15fb13ed
Author: Ben Keen <be...@gmail.com>
Date: 2015-10-02T17:09:17Z
Fix for Safari not recognizing autofill on login form
Safari doesn't trigger change events for form field autofills,
so the state of the login component doesn't updated, triggering
the rather irritating "you didn't fill in all the fields" error
when visually you sure did.
Since existing polyfill options don't work (see ticket), this fix
explicitly checks for the condition of a mismatch of
username-password form values and component state. It's a little
inelegant, but justifiable I think.
Closes COUCHDB-2829
----
> Fauxton username and password do not autofill
> ---------------------------------------------
>
> Key: COUCHDB-2829
> URL: https://issues.apache.org/jira/browse/COUCHDB-2829
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
> Reporter: Garren Smith
> Assignee: Ben Keen
>
> From Jan on IRC:
> Fauxton form validation can’t handle auto-password-fill on login, it’s super annoying to have “password can’t be blank”, when in fact it had been entered, even though there was no user interaction with the form field
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)