You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ruanhang1993 (via GitHub)" <gi...@apache.org> on 2023/03/22 09:51:05 UTC
[GitHub] [flink-connector-kafka] ruanhang1993 opened a new pull request, #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT
ruanhang1993 opened a new pull request, #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9
This PR updates the flink version to 1.18-SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] MartijnVisser commented on a diff in pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#discussion_r1152934651
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT]
+ flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
If we add support for 1.18, then we should drop support for 1.16 per https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development#ExternalizedConnectordevelopment-Flinkcompatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16 [flink-connector-kafka]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#issuecomment-1758278394
This has already been resolved, as shown in this nightly build https://github.com/apache/flink-connector-kafka/actions/runs/6486214259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] ruanhang1993 commented on a diff in pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16
Posted by "ruanhang1993 (via GitHub)" <gi...@apache.org>.
ruanhang1993 commented on code in PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#discussion_r1153024627
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT]
+ flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
Thanks for reminding, @MartijnVisser. Drop 1.16 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#issuecomment-1499758433
I'm not so sure we should merge this.
I believe we want to always develop against the latest stable Flink version, even in `main` branch.
For example in `main` right now, we're using `1.17.0` for the Flink version.
For `1.18-SNAPSHOT`, we rely on nightly builds to ensure we're still compatible with the latest snapshot.
Not entirely sure what the consensus was here, @MartijnVisser can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] ruanhang1993 commented on pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16
Posted by "ruanhang1993 (via GitHub)" <gi...@apache.org>.
ruanhang1993 commented on PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#issuecomment-1490394930
@MartijnVisser There is some compile errors . I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16 [flink-connector-kafka]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16
URL: https://github.com/apache/flink-connector-kafka/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] MartijnVisser commented on pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT and drop support for 1.16
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#issuecomment-1527414205
> I believe we want to always develop against the latest stable Flink version, even in `main` branch.
@tzulitai Ideally yes, but there can be situations where we want a connector to have an implementation for a feature that isn't yet released in Flink. I think that's the case in this situation. If we don't rely on the SNAPSHOT build, we can only start developing the connector implementation when Flink and that new API is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #9: [FLINK-31559][connector/kafka] Update the flink version to 1.18-SNAPSHOT
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #9:
URL: https://github.com/apache/flink-connector-kafka/pull/9#issuecomment-1479235777
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org