You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "FinalT (via GitHub)" <gi...@apache.org> on 2023/07/28 10:31:59 UTC
[GitHub] [dubbo-go] FinalT opened a new pull request, #2366: add registry metrics
FinalT opened a new pull request, #2366:
URL: https://github.com/apache/dubbo-go/pull/2366
dubbo_register_service_rt_milliseconds_avg
dubbo_register_service_rt_milliseconds_last
dubbo_register_service_rt_milliseconds_max
dubbo_register_service_rt_milliseconds_min
dubbo_register_service_rt_milliseconds_sum
dubbo_registry_directory_num_all
dubbo_registry_directory_num_disable_total
dubbo_registry_directory_num_to_reconnect_total
dubbo_registry_directory_num_valid_total
dubbo_registry_notify_num_last
dubbo_registry_notify_requests_total
dubbo_register_rt_milliseconds_max
dubbo_register_rt_milliseconds_avg
dubbo_register_rt_milliseconds_sum
dubbo_register_rt_milliseconds_min
dubbo_register_rt_milliseconds_last
dubbo_registry_register_requests_succeed_total
dubbo_registry_register_requests_total
dubbo_registry_register_requests_failed_total
dubbo_registry_register_service_total
dubbo_registry_register_service_succeed_total
dubbo_registry_register_service_failed_total
dubbo_registry_subscribe_num_failed_total
dubbo_registry_subscribe_num_succeed_total
dubbo_registry_subscribe_num_total
dubbo_registry_subscribe_service_num_total
dubbo_registry_subscribe_service_num_succeed_total
dubbo_registry_subscribe_service_num_failed_total
dubbo_notify_rt_milliseconds_avg
dubbo_notify_rt_milliseconds_last
dubbo_notify_rt_milliseconds_max
dubbo_notify_rt_milliseconds_min
dubbo_notify_rt_milliseconds_sum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2366: add registry metrics
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2366:
URL: https://github.com/apache/dubbo-go/pull/2366#issuecomment-1655458846
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2366)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2366) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2366&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2366: add registry metrics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2366:
URL: https://github.com/apache/dubbo-go/pull/2366#issuecomment-1656668638
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2366](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8592e11) into [feature-metrics](https://app.codecov.io/gh/apache/dubbo-go/commit/d0c35642589e4971880d5033f77593d13ef637d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d0c3564) will **decrease** coverage by `0.04%`.
> The diff coverage is `43.75%`.
> :exclamation: Current head 8592e11 differs from pull request most recent head 642e0e0. Consider uploading reports for the commit 642e0e0 to get more accurate results
```diff
@@ Coverage Diff @@
## feature-metrics #2366 +/- ##
===================================================
- Coverage 44.11% 44.07% -0.04%
===================================================
Files 304 304
Lines 18430 18446 +16
===================================================
Hits 8130 8130
- Misses 9445 9462 +17
+ Partials 855 854 -1
```
| [Files Changed](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [registry/base\_registry.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnkvYmFzZV9yZWdpc3RyeS5nbw==) | `1.39% <0.00%> (-0.02%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `0.95% <0.00%> (-0.02%)` | :arrow_down: |
| [registry/nacos/registry.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `42.51% <66.66%> (+0.44%)` | :arrow_up: |
| [registry/directory/directory.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `73.49% <71.42%> (-0.06%)` | :arrow_down: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go/pull/2366/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2366: add registry metrics
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2366:
URL: https://github.com/apache/dubbo-go/pull/2366#issuecomment-1655462647
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2366)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2366&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2366) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2366&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] chickenlj merged pull request #2366: add registry metrics
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #2366:
URL: https://github.com/apache/dubbo-go/pull/2366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org