You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "aitozi (JIRA)" <ji...@apache.org> on 2018/09/17 15:35:01 UTC
[jira] [Commented] (FLINK-9761) Potential buffer leak in
PartitionRequestClientHandler during job failures
[ https://issues.apache.org/jira/browse/FLINK-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617710#comment-16617710 ]
aitozi commented on FLINK-9761:
-------------------------------
Hi，[~NicoK]
why does the stagedMessagesHandler still should work when the stagesMessages is empty? Do you mean the potential memory leak comes from the visible of the stagesMessages in different thread ?
> Potential buffer leak in PartitionRequestClientHandler during job failures
> --------------------------------------------------------------------------
>
> Key: FLINK-9761
> URL: https://issues.apache.org/jira/browse/FLINK-9761
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Critical
> Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> {{PartitionRequestClientHandler#stagedMessages}} may be accessed from multiple threads:
> 1) Netty's IO thread
> 2) During cancellation, {{PartitionRequestClientHandler.BufferListenerTask#notifyBufferDestroyed}} is called
> If {{PartitionRequestClientHandler.BufferListenerTask#notifyBufferDestroyed}} thinks, {{stagesMessages}} is empty, however, it will not install the {{stagedMessagesHandler}} that consumes and releases buffers from received messages.
> Unless some unexpected combination of code calls prevents this from happening, this would leak the non-recycled buffers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)