You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/24 15:39:42 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #36649: [SPARK-39270][SQL] JDBC dialect supports registering dialect specific functions

cloud-fan commented on code in PR #36649:
URL: https://github.com/apache/spark/pull/36649#discussion_r880673952


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -323,6 +329,26 @@ abstract class JdbcDialect extends Serializable with Logging{
     }
   }
 
+  /**

Review Comment:
   I left a comment in your previous PR as well. Can we make the API simpler? just `def functions: Seq[(Identifier, UnboundFunction)] = Nil` should be sufficient?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org