You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/20 06:36:51 UTC
[GitHub] [commons-configuration] cigaly opened a new pull request #122: Test case and fix for https://issues.apache.org/jira/browse/CONFIGURATION-808
cigaly opened a new pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-869018059
@cigaly May you please rebase on master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] cigaly commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
cigaly commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901111071
I can create completely new pull request if you like.
Anyway, attached is diff of changes.
[CONFIGURATION-808.txt](https://github.com/apache/commons-configuration/files/7007494/CONFIGURATION-808.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901080774
@cigaly
PR is too messy IMO, 46 files changed? Surely this can be boiled down to the essentials. I looks like something went wrong during a merge maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] cigaly commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
cigaly commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901111071
I can create completely new pull request if you like.
Anyway, attached is diff of changes.
[CONFIGURATION-808.txt](https://github.com/apache/commons-configuration/files/7007494/CONFIGURATION-808.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] cigaly closed pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
cigaly closed pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] cigaly commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
cigaly commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901627101
Closed this PR, and created fresh one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] cigaly commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
cigaly commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-869037609
Done ... hopefully correct. It is now passing under JDK 16 & JDK 17. However, fails under JDK 18 :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901349629
> I can create completely new pull request if you like.
>
> Anyway, attached is diff of changes.
>
> [CONFIGURATION-808.txt](https://github.com/apache/commons-configuration/files/7007494/CONFIGURATION-808.txt)
I want a clean PR such that GirHub runs all our builds. Whatever you've done seems worse since now 47 files are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #122: CONFIGURATION-808 - DefaultListDelimiterHandler.escapeList working only for List
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #122:
URL: https://github.com/apache/commons-configuration/pull/122#issuecomment-901080774
@cigaly
PR is too messy IMO, 46 files changed? Surely this can be boiled down to the essentials. I looks like something went wrong during a merge maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org