You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:16:33 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2732: HBASE-25230 Embedded zookeeper server not clean up the old data

virajjasani commented on a change in pull request #2732:
URL: https://github.com/apache/hbase/pull/2732#discussion_r534122009



##########
File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
##########
@@ -88,6 +89,15 @@ public static void main(String[] args) {
 
   private static void runZKServer(QuorumPeerConfig zkConfig)
           throws IOException, AdminServer.AdminServerException {
+
+    // Start and schedule the the purge task
+    DatadirCleanupManager purgeMgr=new DatadirCleanupManager(

Review comment:
       nit: let's mention about `purgeInterval` being 0 by default in comment above this and also the fact that providing this config is recommended only for standalone server.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org