You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/15 23:36:35 UTC

[GitHub] [spark] rxin commented on issue #24339: [SPARK-27436][SQL] Add spark.sql.optimizer.nonExcludedRules

rxin commented on issue #24339: [SPARK-27436][SQL] Add spark.sql.optimizer.nonExcludedRules
URL: https://github.com/apache/spark/pull/24339#issuecomment-483457024
 
 
   I agree with the above -- why have this? Pretty confusing ... Users / admins that use any of the super advanced features should know what they are doing, before attempting to do that. If one really wants to go out of their way to exclude specific rules, there might be a chance that they actually want to exclude a rule that's considered "should not exclude", especially if they end up writing their version of the rule.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org