You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Lav Jain <lj...@pivotal.io> on 2015/12/09 22:41:13 UTC
Review Request 41151: Co-locate HAWQSEGMENT on hosts that have
DATANODE component
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41151/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-14301
https://issues.apache.org/jira/browse/AMBARI-14301
Repository: ambari
Description
-------
Looks like stackadvisor is used only upon a fresh install if no changes are made to the master components. In that case, the client/slaves are installed on all the hosts, so HAWQSEGMENT is co-located with DATANODE by default.
If HDFS is already installed and HAWQ is enabled using add services, then Ambari chooses all hosts that do not have a MASTER component installed. This determination is being done in the javascript code.
This patch is changing the hostlist for HAWQSEGMENT to be the same as DATANODE in the latter case.
Diffs
-----
1f8133d 1f8133d
Diff: https://reviews.apache.org/r/41151/diff/
Testing
-------
Manually tested.
Thanks,
Lav Jain
Re: Review Request 41151: Co-locate HAWQSEGMENT on hosts that have
DATANODE component
Posted by Lav Jain <lj...@pivotal.io>.
> On Dec. 9, 2015, 11:40 p.m., Matt wrote:
> >
Good catch. Will fix it together with other feedback.
- Lav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41151/#review109634
-----------------------------------------------------------
On Dec. 9, 2015, 9:41 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41151/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 9:41 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14301
> https://issues.apache.org/jira/browse/AMBARI-14301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like stackadvisor is used only upon a fresh install if no changes are made to the master components. In that case, the client/slaves are installed on all the hosts, so HAWQSEGMENT is co-located with DATANODE by default.
> If HDFS is already installed and HAWQ is enabled using add services, then Ambari chooses all hosts that do not have a MASTER component installed. This determination is being done in the javascript code.
> This patch is changing the hostlist for HAWQSEGMENT to be the same as DATANODE in the latter case.
>
>
> Diffs
> -----
>
> 1f8133d 1f8133d
>
> Diff: https://reviews.apache.org/r/41151/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41151: Co-locate HAWQSEGMENT on hosts that have
DATANODE component
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41151/#review109634
-----------------------------------------------------------
1f8133d (line 425)
<https://reviews.apache.org/r/41151/#comment169234>
This line should have the same indent as line 419, hostList
- Matt
On Dec. 9, 2015, 1:41 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41151/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 1:41 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14301
> https://issues.apache.org/jira/browse/AMBARI-14301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like stackadvisor is used only upon a fresh install if no changes are made to the master components. In that case, the client/slaves are installed on all the hosts, so HAWQSEGMENT is co-located with DATANODE by default.
> If HDFS is already installed and HAWQ is enabled using add services, then Ambari chooses all hosts that do not have a MASTER component installed. This determination is being done in the javascript code.
> This patch is changing the hostlist for HAWQSEGMENT to be the same as DATANODE in the latter case.
>
>
> Diffs
> -----
>
> 1f8133d 1f8133d
>
> Diff: https://reviews.apache.org/r/41151/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41151: Co-locate HAWQSEGMENT on hosts that have
DATANODE component
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41151/#review110606
-----------------------------------------------------------
ambari-web/app/controllers/main/service/add_controller.js (line 414)
<https://reviews.apache.org/r/41151/#comment170555>
Please add Jaimin Jetly and Richard Zang to the code review.
- Alejandro Fernandez
On Dec. 10, 2015, 4:21 a.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41151/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 4:21 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14301
> https://issues.apache.org/jira/browse/AMBARI-14301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like stackadvisor is used only upon a fresh install if no changes are made to the master components. In that case, the client/slaves are installed on all the hosts, so HAWQSEGMENT is co-located with DATANODE by default.
> If HDFS is already installed and HAWQ is enabled using add services, then Ambari chooses all hosts that do not have a MASTER component installed. This determination is being done in the javascript code.
> This patch is changing the hostlist for HAWQSEGMENT to be the same as DATANODE in the latter case.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/add_controller.js 1f8133d
>
> Diff: https://reviews.apache.org/r/41151/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 41151: Co-locate HAWQSEGMENT on hosts that have
DATANODE component
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41151/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 4:21 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Matt, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-14301
https://issues.apache.org/jira/browse/AMBARI-14301
Repository: ambari
Description
-------
Looks like stackadvisor is used only upon a fresh install if no changes are made to the master components. In that case, the client/slaves are installed on all the hosts, so HAWQSEGMENT is co-located with DATANODE by default.
If HDFS is already installed and HAWQ is enabled using add services, then Ambari chooses all hosts that do not have a MASTER component installed. This determination is being done in the javascript code.
This patch is changing the hostlist for HAWQSEGMENT to be the same as DATANODE in the latter case.
Diffs (updated)
-----
ambari-web/app/controllers/main/service/add_controller.js 1f8133d
Diff: https://reviews.apache.org/r/41151/diff/
Testing
-------
Manually tested.
Thanks,
Lav Jain