You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 20:09:12 UTC
[GitHub] [airflow-client-go] houqp opened a new pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
houqp opened a new pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10
Depends on https://github.com/apache/airflow/pull/16411.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] houqp commented on pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10#issuecomment-861194461
from master, I will regen it with `2.1.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] houqp commented on a change in pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10#discussion_r651249803
##########
File path: README.md
##########
@@ -36,19 +36,18 @@ import (
)
func main() {
- cli := airflow.NewAPIClient(&airflow.Configuration{
- Scheme: "http",
- Host: "localhost:8080",
- BasePath: "/api/v1",
- })
+ conf := airflow.NewConfiguration()
+ conf.Host = "localhost:8080"
+ conf.Scheme = "http"
+ cli := airflow.NewAPIClient(conf)
cred := airflow.BasicAuth{
UserName: "username",
Password: "password",
}
ctx := context.WithValue(context.Background(), airflow.ContextBasicAuth, cred)
- variable, _, err := cli.VariableApi.GetVariable(ctx, "foo")
+ variable, _, err := cli.VariableApi.GetVariable(ctx, "foo").Execute()
Review comment:
unfortunately openapi-generator 5.x introduced breaking change in their go code gen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] msumit commented on pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10#issuecomment-861159943
@houqp did u generate this code from Airflow's 2.1.0 tag or from master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] potiuk commented on pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10#issuecomment-861363359
Or `main` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-client-go] houqp merged pull request #10: upgrade go client to latest api spec using openapi-generator 5.x
Posted by GitBox <gi...@apache.org>.
houqp merged pull request #10:
URL: https://github.com/apache/airflow-client-go/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org