[GitHub] leezu opened a new pull request #12245: Don't override global warnings filter

[GitBox <gi...@apache.org>]

leezu opened a new pull request #12245: Don't override global warnings filter
URL: https://github.com/apache/incubator-mxnet/pull/12245
 
 
   ## Description ##
   Currently import mxnet causes warnings.filterwarnings('default', category=DeprecationWarning) to be executed.
   This is very bad, as there are valid use cases where our users may have decided to filter out DeprecationWarning and we should not overwrite their configuration.
   
   It is also not always possible for users to change the warnings filter after mxnet has changed it. Consider a package that relies on mxnet (such as https://github.com/dmlc/gluon-nlp ) but also imports third-party packages that may raise warnings. If now gluon-nlp is imported, mxnet will overwrite the warnings filter and the user has no option to change it back to whatever settings he needs before gluon-nlp goes on to import other packages that may raise warnings.
   
   ### Changes ###
   - [X] Don't overwride global warnings.filterwarnings filter
   
   ### Comments ###
   @szha This breaks our notebooks for KDD18
   @Roshrini  Can we get this into mxnet 1.3 please? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services