[GitHub] [geode-benchmarks] Bill commented on a change in pull request #129: TLS SNI support via "withSniProxy" Option

[GitBox <gi...@apache.org>]

Bill commented on a change in pull request #129:
URL: https://github.com/apache/geode-benchmarks/pull/129#discussion_r436285220



##########
File path: geode-benchmarks/build.gradle
##########
@@ -23,16 +23,29 @@ version '1.0-SNAPSHOT'
 sourceCompatibility = 1.8
 
 def outputDir = project.hasProperty('outputDir') ? project.findProperty('outputDir') : new File(project.buildDir, "benchmarks_" + getDate()).getAbsolutePath()
-def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.+'
+def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.13.+'
 
 def getDate() {
   new Date().format('yyyyMMddHHmmss')
 }
 
 
 repositories {
+  // in CI we want to search mavenLocal for geode
   mavenLocal()
-  mavenCentral()
+  // non-geode stuff can come from mavenCentral
+  mavenCentral() {
+    content {
+      excludeGroup 'org.apache.geode'
+    }
+  }
+  // when developing this project, use Geode develop branch snapshot
+  maven {
+    url "https://maven.apachegeode-ci.info/snapshots"
+    content {
+      includeGroup 'org.apache.geode'
+    }
+  }

Review comment:
       That works in CI but it doesn't, in general, work in the dev environment.
   
   Are you suggesting a workflow in the dev environment, where you clone the `geode` repo and then `./gradlew publishToMavenLocal` before working in the `geode-benchmarks` repo?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org