You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by isoutham <gi...@git.apache.org> on 2015/06/10 11:17:02 UTC
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
GitHub user isoutham opened a pull request:
https://github.com/apache/cloudstack/pull/381
Allow test to run on tiny linux templates using busybox
When running in test environments containing netted-nested hypervisors, the centos template is a little "heavy". This test presumes that apache will be installed on the target system which is not the case with tiny linux as it is busy box based.
Just adds some extra code to detect the busy box binary and use it if it is there.
Test succeeds under KVM and Xen running tiny linux and centos.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isoutham/cloudstack test_vpc_network_pfrules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #381
----
commit d3616016b0eb3f8f48b2e8ec2819b557ba60a4f0
Author: Ian Southam <is...@schubergphilis.com>
Date: 2015-06-10T09:12:17Z
Allow test to run on tiny linux templates using busybox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/381
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by isoutham <gi...@git.apache.org>.
Github user isoutham commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110892103
Hi,
Yes merge it please. Test 03 does not fail to me. Might be an idea to
increase the retry count for people running slow ivm systems. I will look
into that and generate another PR if necessary.
Thanks
Ian
On 10 June 2015 at 21:46, Wilder Rodrigues <no...@github.com> wrote:
> XenServer results:
>
> Test : Create VPC PF rules on acquired public ip when VpcVirtualRouter is
> stopped ... === TestName: test_01_network_services_VPC_StopCreatePF |
> Status : SUCCESS ===
> ok
> Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is
> Running ... === TestName: test_02_network_services_VPC_CreatePF | Status :
> SUCCESS ===
> ok
> Test Create multiple VPC PF rules on acquired public ip in diff't networks
> when VpcVirtualRouter is stopped ... === TestName:
> test_03_network_services_VPC_StopCreateMultiplePF | Status : SUCCESS ===
> ok
> Test Create multiple VPC PF rules on acquired public ip in diff't networks
> when VpcVirtualRouter is running ... === TestName:
> test_04_network_services_VPC_CreateMultiplePF | Status : SUCCESS ===
> ok
> Test delete a PF rule in VPC when VpcVirtualRouter is Stopped ... ===
> TestName: test_05_network_services_VPC_StopDeletePF | Status : SUCCESS ===
> ok
> Test delete a PF rule in VPC when VpcVirtualRouter is Running ... ===
> TestName: test_06_network_services_VPC_DeletePF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC when VpcVirtualRouter is Stopped ... ===
> TestName: test_07_network_services_VPC_StopDeleteAllPF | Status : SUCCESS
> ===
> ok
> Test delete all PF rules in VPC when VpcVirtualRouter is Running ... ===
> TestName: test_08_network_services_VPC_DeleteAllPF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC across multiple networks when
> VpcVirtualRouter is Stopped ... === TestName:
> test_09_network_services_VPC_StopDeleteAllMultiplePF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC across multiple networks when
> VpcVirtualRouter is Running ... === TestName:
> test_10_network_services_VPC_DeleteAllMultiplePF | Status : SUCCESS ===
> ok
> ------------------------------
>
> Ran 10 tests in 4615.940s
>
> KVM results:
>
> Test : Create VPC PF rules on acquired public ip when VpcVirtualRouter is
> stopped ... === TestName: test_01_network_services_VPC_StopCreatePF |
> Status : SUCCESS ===
> ok
> Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is
> Running ... === TestName: test_02_network_services_VPC_CreatePF | Status :
> SUCCESS ===
> ok
> Test Create multiple VPC PF rules on acquired public ip in diff't networks
> when VpcVirtualRouter is stopped ... === TestName:
> test_03_network_services_VPC_StopCreateMultiplePF | Status : FAILED ===
> FAIL
> Test Create multiple VPC PF rules on acquired public ip in diff't networks
> when VpcVirtualRouter is running ... === TestName:
> test_04_network_services_VPC_CreateMultiplePF | Status : SUCCESS ===
> ok
> Test delete a PF rule in VPC when VpcVirtualRouter is Stopped ... ===
> TestName: test_05_network_services_VPC_StopDeletePF | Status : SUCCESS ===
> ok
> Test delete a PF rule in VPC when VpcVirtualRouter is Running ... ===
> TestName: test_06_network_services_VPC_DeletePF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC when VpcVirtualRouter is Stopped ... ===
> TestName: test_07_network_services_VPC_StopDeleteAllPF | Status : SUCCESS
> ===
> ok
> Test delete all PF rules in VPC when VpcVirtualRouter is Running ... ===
> TestName: test_08_network_services_VPC_DeleteAllPF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC across multiple networks when
> VpcVirtualRouter is Stopped ... === TestName:
> test_09_network_services_VPC_StopDeleteAllMultiplePF | Status : SUCCESS ===
> ok
> Test delete all PF rules in VPC across multiple networks when
> VpcVirtualRouter is Running ... === TestName:
> test_10_network_services_VPC_DeleteAllMultiplePF | Status : SUCCESS ===
> ok
> FAIL: Test Create multiple VPC PF rules on acquired public ip in diff't
> networks when VpcVirtualRouter is stopped
>
> @isoutham <https://github.com/isoutham>
>
> 1 test failed on KVM with the following trace:
>
> Traceback (most recent call last):
> File
> "/root/dev/cloudstack/test/integration/component/test_vpc_network_pfrules.py",
> line 607, in test_03_network_services_VPC_StopCreateMultiplePF
> self.check_ssh_into_vm(vm_2, public_ip_2, testnegative=False)
> File
> "/root/dev/cloudstack/test/integration/component/test_vpc_network_pfrules.py",
> line 327, in check_ssh_into_vm
> self.fail("Failed to SSH into VM - %s" % (public_ip.ipaddress.ipaddress))
> AssertionError: Failed to SSH into VM - 192.168.23.6
>
> Perhaps that was due to the slowness of the KVM machines.
>
> Is that okay with you if I merge the PR?
>
> Cheers,
> Wilder
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/381#issuecomment-110889882>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110806055
@isoutham
False alarm!
The template was ready, but the configuration file was not correct: there was a typo on the command line and it was loading another configuration instead of the one I used to create the Zone.
Tests are running now.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110892310
Super!
Thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110889882
XenServer results:
Test : Create VPC PF rules on acquired public ip when VpcVirtualRouter is stopped ... === TestName: test_01_network_services_VPC_StopCreatePF | Status : SUCCESS ===
ok
Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is Running ... === TestName: test_02_network_services_VPC_CreatePF | Status : SUCCESS ===
ok
Test Create multiple VPC PF rules on acquired public ip in diff't networks when VpcVirtualRouter is stopped ... === TestName: test_03_network_services_VPC_StopCreateMultiplePF | Status : SUCCESS ===
ok
Test Create multiple VPC PF rules on acquired public ip in diff't networks when VpcVirtualRouter is running ... === TestName: test_04_network_services_VPC_CreateMultiplePF | Status : SUCCESS ===
ok
Test delete a PF rule in VPC when VpcVirtualRouter is Stopped ... === TestName: test_05_network_services_VPC_StopDeletePF | Status : SUCCESS ===
ok
Test delete a PF rule in VPC when VpcVirtualRouter is Running ... === TestName: test_06_network_services_VPC_DeletePF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC when VpcVirtualRouter is Stopped ... === TestName: test_07_network_services_VPC_StopDeleteAllPF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC when VpcVirtualRouter is Running ... === TestName: test_08_network_services_VPC_DeleteAllPF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC across multiple networks when VpcVirtualRouter is Stopped ... === TestName: test_09_network_services_VPC_StopDeleteAllMultiplePF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC across multiple networks when VpcVirtualRouter is Running ... === TestName: test_10_network_services_VPC_DeleteAllMultiplePF | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 4615.940s
KVM results:
Test : Create VPC PF rules on acquired public ip when VpcVirtualRouter is stopped ... === TestName: test_01_network_services_VPC_StopCreatePF | Status : SUCCESS ===
ok
Test Create VPC PF rules on acquired public ip when VpcVirtualRouter is Running ... === TestName: test_02_network_services_VPC_CreatePF | Status : SUCCESS ===
ok
Test Create multiple VPC PF rules on acquired public ip in diff't networks when VpcVirtualRouter is stopped ... === TestName: test_03_network_services_VPC_StopCreateMultiplePF | Status : FAILED ===
FAIL
Test Create multiple VPC PF rules on acquired public ip in diff't networks when VpcVirtualRouter is running ... === TestName: test_04_network_services_VPC_CreateMultiplePF | Status : SUCCESS ===
ok
Test delete a PF rule in VPC when VpcVirtualRouter is Stopped ... === TestName: test_05_network_services_VPC_StopDeletePF | Status : SUCCESS ===
ok
Test delete a PF rule in VPC when VpcVirtualRouter is Running ... === TestName: test_06_network_services_VPC_DeletePF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC when VpcVirtualRouter is Stopped ... === TestName: test_07_network_services_VPC_StopDeleteAllPF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC when VpcVirtualRouter is Running ... === TestName: test_08_network_services_VPC_DeleteAllPF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC across multiple networks when VpcVirtualRouter is Stopped ... === TestName: test_09_network_services_VPC_StopDeleteAllMultiplePF | Status : SUCCESS ===
ok
Test delete all PF rules in VPC across multiple networks when VpcVirtualRouter is Running ... === TestName: test_10_network_services_VPC_DeleteAllMultiplePF | Status : SUCCESS ===
ok
======================================================================
FAIL: Test Create multiple VPC PF rules on acquired public ip in diff't networks when VpcVirtualRouter is stopped
----------------------------------------------------------------------
@isoutham
1 test failed on KVM with the following trace:
Traceback (most recent call last):
File "/root/dev/cloudstack/test/integration/component/test_vpc_network_pfrules.py", line 607, in test_03_network_services_VPC_StopCreateMultiplePF
self.check_ssh_into_vm(vm_2, public_ip_2, testnegative=False)
File "/root/dev/cloudstack/test/integration/component/test_vpc_network_pfrules.py", line 327, in check_ssh_into_vm
self.fail("Failed to SSH into VM - %s" % (public_ip.ipaddress.ipaddress))
AssertionError: Failed to SSH into VM - 192.168.23.6
Perhaps that was due to the slowness of the KVM machines.
Is that okay with you if I merge the PR?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by Remi Bergsma <re...@remi.nl>.
LGTM, will try to give it a test drive today. Thanks!
Sent from my iPhone
> On 10 Jun 2015, at 11:17, isoutham <gi...@git.apache.org> wrote:
>
> GitHub user isoutham opened a pull request:
>
> https://github.com/apache/cloudstack/pull/381
>
> Allow test to run on tiny linux templates using busybox
>
> When running in test environments containing netted-nested hypervisors, the centos template is a little "heavy". This test presumes that apache will be installed on the target system which is not the case with tiny linux as it is busy box based.
>
> Just adds some extra code to detect the busy box binary and use it if it is there.
>
> Test succeeds under KVM and Xen running tiny linux and centos.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/isoutham/cloudstack test_vpc_network_pfrules
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/381.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #381
>
> ----
> commit d3616016b0eb3f8f48b2e8ec2819b557ba60a4f0
> Author: Ian Southam <is...@schubergphilis.com>
> Date: 2015-06-10T09:12:17Z
>
> Allow test to run on tiny linux templates using busybox
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110800931
@isoutham
The KVM tests are running. I had problems with my environment (as you might have seen on Slcak) and had to restart them. However, when I try to run the tests on XenServer62 I get the following error:
CSLog: CRITICAL: EXCEPTION: None: ['Traceback (most recent call last):\n', ' File "/usr/lib/python2.7/site-packages/nose-1.3.6-py2.7.egg/nose/suite.py", line 209, in run\n self.setUp()\n', ' File "/usr/lib/python2.7/site-packages/nose-1.3.6-py2.7.egg/nose/suite.py", line 292, in setUp\n self.setupContext(ancestor)\n', ' File "/usr/lib/python2.7/site-packages/nose-1.3.6-py2.7.egg/nose/suite.py", line 315, in setupContext\n try_run(context, names)\n', ' File "/usr/lib/python2.7/site-packages/nose-1.3.6-py2.7.egg/nose/util.py", line 471, in try_run\n return func()\n', ' File "/data/git/cs2/cloudstack/test/integration/component/test_vpc_network_pfrules.py", line 195, in setUpClass\n cls.zone.id,\n', "AttributeError: 'str' object has no attribute 'id'\n"]
On line 195 we have the following:
cls.template = get_template(
cls.api_client,
195 here ===> cls.zone.id,
cls.services["ostype"]
)
It seems that the test can't retrieve the zone when using XenServer, which is very weird.
As I mentioned above, KVM runs just fine! Tests haven't completed yet, but everything seems okay:
====Trying SSH Connection: Host:192.168.23.5 User:root Port:22 RetryCnt:14===
====Trying SSH Connection: Host:192.168.23.5 User:root Port:22 RetryCnt:14===
===SSH to Host 192.168.23.5 port : 22 SUCCESSFUL===
===SSH to Host 192.168.23.5 port : 22 SUCCESSFUL===
=== TestName: test_02_network_services_VPC_CreatePF | Status : SUCCESS ===
Do you have any idea what that might be?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110667017
Once travis is done I will test and merge this one.
Thanks, @isoutham
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Allow test to run on tiny linux templates...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/381#issuecomment-110697462
I started testing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---