You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/05/21 19:25:16 UTC
[jira] Created: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
--------------------------------------------------------------------------
Key: HADOOP-1397
URL: https://issues.apache.org/jira/browse/HADOOP-1397
Project: Hadoop
Issue Type: Improvement
Components: contrib/hbase
Reporter: stack
Priority: Minor
HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman resolved HADOOP-1397.
-----------------------------------
Resolution: Fixed
I have committed this. Thanks, Michael!
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397-v2.patch, hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498602 ]
Hadoop QA commented on HADOOP-1397:
-----------------------------------
Integrated in Hadoop-Nightly #99 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/99/)
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397-v2.patch, hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1397:
--------------------------
Attachment: hadoop1397-v2.patch
Chatting with Hairong.... here is a patch that should apply cleanly to r540346. Original patch against a clean r540346 checkout was doing below:
$ patch -p0 < ../hadoop-dev/hadoop1397.patch
patching file src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
patching file src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegionServer.java
Hunk #8 succeeded at 757 (offset 12 lines).
Hunk #9 succeeded at 789 (offset 12 lines).
Hunk #10 succeeded at 812 (offset 12 lines).
Hunk #11 succeeded at 844 (offset 12 lines).
Hunk #12 succeeded at 856 (offset 12 lines).
Hunk #13 succeeded at 1018 (offset 12 lines).
patching file src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
Hairong, if you are seeing other than the above -- actual rejections -- let me know. Thanks.
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397-v2.patch, hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497826 ]
Hadoop QA commented on HADOOP-1397:
-----------------------------------
Integrated in Hadoop-Nightly #97 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/97/)
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397-v2.patch, hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1397:
--------------------------
Attachment: hadoop1397.patch
Here is a patch that replaces all instances of HLocking with instances of ReentrantReadWriteLock.
Hairong Kuang: Any chance you'd try this patch on your machine first before I mark this issue with patch available'. I would like to be sure that this patch does not introduce regression of HADOOP-1341 "TestHBaseCluster fails with IllegalMonitorStateException" (I've run unit tests on a couple of machines, both single and multiprocessor and it passes fine). Thanks Hairong.
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1397) Replace custom hbase locking with
java.util.concurrent.locks.ReentrantLock
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497697 ]
Hairong Kuang commented on HADOOP-1397:
---------------------------------------
+1 I have ran TestHBaseCluster for 7 times without seeing a failure.
For the first patch, I applied through Eclipse. I saw two unchecked boxes on GUI. So I thought it did not apply.
> Replace custom hbase locking with java.util.concurrent.locks.ReentrantLock
> --------------------------------------------------------------------------
>
> Key: HADOOP-1397
> URL: https://issues.apache.org/jira/browse/HADOOP-1397
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: hadoop1397-v2.patch, hadoop1397.patch
>
>
> HBase has a locking class that is effectively a clone of java.util.concurrent.locks.ReentrantLock. This issue is about replacing HLocking with the java native implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.