You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/03/08 22:13:23 UTC
[GitHub] couchdb-fauxton pull request: Style update for metadata page
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/663
Style update for metadata page
The metadata page was kinda ugly, and Tim White recently made
a few aesthetic changes to the page. This implements them and
generally smartens up the page a bit.
### Old page
<img width="1110" alt="metadata-page-old" src="https://cloud.githubusercontent.com/assets/512116/13616604/7ca67322-e52f-11e5-8a75-45b4c4b784fb.png">
### New page
<img width="1214" alt="metadata-page-new" src="https://cloud.githubusercontent.com/assets/512116/13616613/844715a0-e52f-11e5-97c7-0de19d326f53.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton metadata-page-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/663.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #663
----
commit 95488df98a23c80d567683b97635458a3957d016
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-08T21:11:47Z
Style update for metadata page
The metadata page was kinda ugly, and Tim White recently made
a few aesthetic changes to the page. This implements them and
generally smartens up the page a bit.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-205344422
Thanks @garrensmith. Merged as f6a1f82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194401530
Cool!
- I don't mind dropping the headings at all. Not sure they added much. But the gaps between the sections seem odd now - could we remove them? It's all just info, anyway.
- wonder if `language: javascript` is useful? Is a doc ever not in JS? (cc @robertkowalski)
- I miss the horizontal rule. The page just looks a lot smarter with it, I think. We use horizontal rules elsewhere.
- The copy-to-clipboard signature is very clever :) I like it.
- I personally don't like the right alignment of the second col. I don't find it more readable and to me it feels out of place somehow (do we do this anywhere else in the application at all?) But if you feel strongly on it, I'm game.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-203904853
I'm getting this error
`bundle.js:135902 Uncaught TypeError: Cannot read property 'toLocaleString' of undefined`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194410189
I feel strongly about consistent alignment (and wish it was used throughout our application, too). :)
I'd like to see spacing used to separate different types of values. If you remove the one between purge sequence and data, I'd on board, but I think the other spaces allow you to visually group certain data types.
I accidentally covered the horizontal rule, and am completely fine with it coming back.
Thanks much, Ben.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194095712
How about something like this (and hear me out)?
- Detailed field labels will help in understanding the metadata.
- The sub-headings don't currently provide much logical organization.
- Consistent justification (and units) should help in understanding values at a glance. And there shouldn't be massive orders of difference between actual data sizes and size on disk.
- The signature isn't going to mean anything on visual glance, so we can stick it under the copy-to-clipboard action.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-204107230
Curious. Couldn't reproduce, but I made the code a bit more defensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-205184081
+1 working for me now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Style update for metadata page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/663
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---