You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2014/05/10 01:24:34 UTC

Re: r1592723: Add 'svnadmin delrevprop'.

Hi Daniel. It looks like your change created this warning:

subversion/svnadmin/svnadmin.c: In function 'subcommand_delrevprop':
subversion/svnadmin/svnadmin.c:2304:27: unused variable 'filename'


- Julian

Re: r1592723: Add 'svnadmin delrevprop'.

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.

Julian Foad wrote on Sat, May 10, 2014 at 00:24:34 +0100:
> Hi Daniel. It looks like your change created this warning:
> 
> subversion/svnadmin/svnadmin.c: In function 'subcommand_delrevprop':
> subversion/svnadmin/svnadmin.c:2304:27: unused variable 'filename'

Thanks Julian.  I missed it (and so did svn-warnings).  Fixed in r1593652.

Separately, your two emails make me wonder if we should change the
commit messages' format to include the first line of the log message in
the subject line.  The https://git-wip-us.apache.org/ repositories can
do this, and I've found that the first paragraph of the log message
usually serves well as a summary of the change for STATUS purposes.

In fact, making the log messages more prominent may encourage us to
write better summaries.

Daniel