You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/22 11:25:27 UTC

[GitHub] [hudi] wangxianghu opened a new pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

wangxianghu opened a new pull request #2473:
URL: https://github.com/apache/hudi/pull/2473


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *Add back dependency org.apache.flink:flink-connector-kafka-base_2.11*
   Fix 
   ```
   java.lang.NoClassDefFoundError: org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase
   	at java.lang.ClassLoader.defineClass1(Native Method)
   	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
   	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
   	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
   	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
   ```
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765808074


   > Good catch. Lets file a JIRA to close the testing gap around this?
   > 
   > Please merge into master when ready. I will port to 0.7.0 branch to do a RC2
   
   filed here: https://issues.apache.org/jira/browse/HUDI-1544


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765494536


   I will time out in an hour and merge/land myself to do RC2 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765805235


   > @wangxianghu have you verified that this fix makes the flink path happy? i.e any more fixes to do?
   
   I tested it in our dev env, it is ok now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-783124508


   > I have a question about this pr, is there any reason we don't want to use Flink 1.12.0? Looks like `FlinkKafkaConsumerBase` is also avaiable in `flink-connector-kafka_2.12`.
   
   There are some other conflicts for the Flink release 1.12.0, that means, the Flink 1.12.0 code can not run successfully on Flink 1.11.0 base jars.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765492708


   Good catch. Lets file a JIRA to close the testing gap around this? 
   
   Please merge into master when ready. I will port to 0.7.0 branch to do a RC2 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765561509


   @wangxianghu have you verified that this fix makes the flink path happy? i.e any more fixes to do?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765344317


   @yanghua please take a look when free


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] zhedoubushishi commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-782280046


   I have a question about this pr, is there any reason we don't want to use Flink 1.12.0? Looks like ```FlinkKafkaConsumerBase``` is also avaiable in ```flink-connector-kafka_2.12```. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] leesf commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765448614


   @yanghua @danny0405 please also take a pass here. and this patch should be merged into 0.7.0 cc @vinothchandar 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-io edited a comment on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765405863






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-io commented on pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2473:
URL: https://github.com/apache/hudi/pull/2473#issuecomment-765405863


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/2473?src=pr&el=h1) Report
   > Merging [#2473](https://codecov.io/gh/apache/hudi/pull/2473?src=pr&el=desc) (35d5773) into [master](https://codecov.io/gh/apache/hudi/commit/048633da1a913a05252b1b5dea0b3d40d75c81b4?el=desc) (048633d) will **increase** coverage by `19.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/2473/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/2473?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #2473       +/-   ##
   =============================================
   + Coverage     50.17%   69.43%   +19.25%     
   + Complexity     3050      357     -2693     
   =============================================
     Files           419       53      -366     
     Lines         18931     1930    -17001     
     Branches       1948      230     -1718     
   =============================================
   - Hits           9498     1340     -8158     
   + Misses         8657      456     -8201     
   + Partials        776      134      -642     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | hudicli | `?` | `?` | |
   | hudiclient | `?` | `?` | |
   | hudicommon | `?` | `?` | |
   | hudiflink | `?` | `?` | |
   | hudihadoopmr | `?` | `?` | |
   | hudisparkdatasource | `?` | `?` | |
   | hudisync | `?` | `?` | |
   | huditimelineservice | `?` | `?` | |
   | hudiutilities | `69.43% <ø> (ø)` | `0.00 <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2473?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/hudi/common/util/collection/ImmutableTriple.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9JbW11dGFibGVUcmlwbGUuamF2YQ==) | | | |
   | [.../org/apache/hudi/cli/commands/MetadataCommand.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL01ldGFkYXRhQ29tbWFuZC5qYXZh) | | | |
   | [...udi/common/table/timeline/dto/CompactionOpDTO.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL2R0by9Db21wYWN0aW9uT3BEVE8uamF2YQ==) | | | |
   | [.../apache/hudi/common/util/DefaultSizeEstimator.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvRGVmYXVsdFNpemVFc3RpbWF0b3IuamF2YQ==) | | | |
   | [...e/hudi/exception/HoodieRecordMissingException.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVJlY29yZE1pc3NpbmdFeGNlcHRpb24uamF2YQ==) | | | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllRGF0YVNvdXJjZUhlbHBlcnMuamF2YQ==) | | | |
   | [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | | | |
   | [.../hudi/common/util/collection/LazyFileIterable.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9MYXp5RmlsZUl0ZXJhYmxlLmphdmE=) | | | |
   | [...ache/hudi/common/fs/SizeAwareDataOutputStream.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL1NpemVBd2FyZURhdGFPdXRwdXRTdHJlYW0uamF2YQ==) | | | |
   | [...udi/common/util/queue/BoundedInMemoryExecutor.java](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvcXVldWUvQm91bmRlZEluTWVtb3J5RXhlY3V0b3IuamF2YQ==) | | | |
   | ... and [356 more](https://codecov.io/gh/apache/hudi/pull/2473/diff?src=pr&el=tree-more) | |
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar merged pull request #2473: [HOTFIX] Revert upgrade flink verison to 1.12.0

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #2473:
URL: https://github.com/apache/hudi/pull/2473


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org