You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kiyonari Harigae <la...@cloudysunny14.org> on 2014/12/10 16:45:12 UTC
Review Request 28904: echo command in sh doesn't have options
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
echo command in sh doesn't have options
sh: echo: I/O error occurs, It is not possible to set the port range.
Also, echo in /bin/sh performs output a (horizontal) tab character
when encountered the escape sequence of \t.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
Diff: https://reviews.apache.org/r/28904/diff/
Testing
-------
Thanks,
Kiyonari Harigae
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Kiyonari Harigae <la...@cloudysunny14.org>.
> On 12月 10, 2014, 5:30 p.m., Dominic Hamon wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2649
> > <https://reviews.apache.org/r/28904/diff/1/?file=788206#file788206line2649>
> >
> > this will fail in bash as the \t will be literal.
Thank you for comment.
Shebang line in generated script is #!/bin/sh,
that the script is actually executed in a POSIX Mode.
http://www.gnu.org/software/bash/manual/bashref.html#Bash-POSIX-Mode
- Kiyonari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64572
-----------------------------------------------------------
On 12月 10, 2014, 3:45 p.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated 12月 10, 2014, 3:45 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64572
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/28904/#comment107337>
this will fail in bash as the \t will be literal.
- Dominic Hamon
On Dec. 10, 2014, 7:45 a.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 7:45 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64561
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28904]
All tests passed.
- Mesos ReviewBot
On Dec. 10, 2014, 3:45 p.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 3:45 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64826
-----------------------------------------------------------
Ship it!
Ship It!
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/28904/#comment107614>
oh great. i wonder how this was working.
- Dominic Hamon
On Dec. 10, 2014, 7:45 a.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 7:45 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Kiyonari Harigae <la...@cloudysunny14.org>.
> On 12月 12, 2014, 1:22 a.m., Ian Downes wrote:
> > I too am not sure how this was working before. What environment did you see this under?
> >
> > We don't actually need to use a tab to separate the values when writing to the special file; let's remove that as well:
> > ```
> > sh-4.1# cat /proc/sys/net/ipv4/ip_local_port_range
> > 32678 61000
> > sh-4.1# echo 32678 61001 > /proc/sys/net/ipv4/ip_local_port_range # range is just space separated
> > sh-4.1# cat /proc/sys/net/ipv4/ip_local_port_range
> > 32678 61001
> > ```
Thank you for comment.
My environment is Ubuntu 14.04 LTS (GNU/Linux 3.13.0 x86_64) , and I have applied patches to kernel along with
http://mesos.apache.org/documentation/latest/network-monitoring/
Yes, Actually don't need seperate by tab.
- Kiyonari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64840
-----------------------------------------------------------
On 12月 12, 2014, 12:40 a.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated 12月 12, 2014, 12:40 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64840
-----------------------------------------------------------
I too am not sure how this was working before. What environment did you see this under?
We don't actually need to use a tab to separate the values when writing to the special file; let's remove that as well:
```
sh-4.1# cat /proc/sys/net/ipv4/ip_local_port_range
32678 61000
sh-4.1# echo 32678 61001 > /proc/sys/net/ipv4/ip_local_port_range # range is just space separated
sh-4.1# cat /proc/sys/net/ipv4/ip_local_port_range
32678 61001
```
- Ian Downes
On Dec. 11, 2014, 4:40 p.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 4:40 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64918
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28904]
All tests passed.
- Mesos ReviewBot
On Dec. 12, 2014, 4:22 p.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 4:22 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64923
-----------------------------------------------------------
[~idownes] can you commit this if it looks good to you?
- Dominic Hamon
On Dec. 12, 2014, 8:22 a.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 8:22 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64933
-----------------------------------------------------------
Ship it!
Thank you for fixing this. I'll get this committed.
- Jie Yu
On Dec. 12, 2014, 4:22 p.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 4:22 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64922
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Dec. 12, 2014, 8:22 a.m., Kiyonari Harigae wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 8:22 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> echo command in sh doesn't have options
>
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
>
> Diff: https://reviews.apache.org/r/28904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kiyonari Harigae
>
>
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Kiyonari Harigae <la...@cloudysunny14.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/
-----------------------------------------------------------
(Updated 12月 12, 2014, 4:22 p.m.)
Review request for mesos and Ian Downes.
Changes
-------
Removed tab character
Repository: mesos-git
Description
-------
echo command in sh doesn't have options
sh: echo: I/O error occurs, It is not possible to set the port range.
Also, echo in /bin/sh performs output a (horizontal) tab character
when encountered the escape sequence of \t.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
Diff: https://reviews.apache.org/r/28904/diff/
Testing
-------
Thanks,
Kiyonari Harigae
Re: Review Request 28904: echo command in sh doesn't have options
Posted by Kiyonari Harigae <la...@cloudysunny14.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 4:40 p.m.)
Review request for mesos and Ian Downes.
Repository: mesos-git
Description
-------
echo command in sh doesn't have options
sh: echo: I/O error occurs, It is not possible to set the port range.
Also, echo in /bin/sh performs output a (horizontal) tab character
when encountered the escape sequence of \t.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262
Diff: https://reviews.apache.org/r/28904/diff/
Testing
-------
Thanks,
Kiyonari Harigae