[GitHub] [incubator-superset] villebro commented on a change in pull request #10037: fix: native annotations broken

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#discussion_r438845534



##########
File path: superset/views/annotations.py
##########
@@ -103,7 +103,7 @@ class AnnotationLayerModelView(SupersetModelView):  # pylint: disable=too-many-a
     add_title = _("Add Annotation Layer")
     edit_title = _("Edit Annotation Layer")
 
-    list_columns = ["name", "descr"]
+    list_columns = ["id", "name", "descr"]

Review comment:
       This will make the CRUD view slightly uglier with the `id`, but is necessary based on discussions with @dpgaspar 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org