You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/23 01:39:06 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10487: Move out functions with one call from library - libraries/_pylint.sh
mik-laj opened a new pull request #10487:
URL: https://github.com/apache/airflow/pull/10487
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #10487: Move out functions with one call from library - libraries/_pylint.sh
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10487:
URL: https://github.com/apache/airflow/pull/10487#issuecomment-706789520
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10487: Move out functions with one call from library - libraries/_pylint.sh
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10487:
URL: https://github.com/apache/airflow/pull/10487#issuecomment-678767948
Besides this _all_libs is purely an "include" one - I think it's much worse to make one function not included in "all_include" file. I am not sure what we want to achieve here, really. One file less? is it worth to do it by mixing abstraction layers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed pull request #10487: Move out functions with one call from library - libraries/_pylint.sh
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #10487:
URL: https://github.com/apache/airflow/pull/10487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org