You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/24 08:28:18 UTC

[GitHub] [spark] itholic commented on a diff in pull request #37955: [SPARK-40512][SPARK-40576][PS][INFRA] Upgrade pandas to 1.5.0

itholic commented on code in PR #37955:
URL: https://github.com/apache/spark/pull/37955#discussion_r1003030319


##########
python/pyspark/pandas/base.py:
##########
@@ -867,7 +867,7 @@ def isin(self: IndexOpsLike, values: Sequence[Any]) -> IndexOpsLike:
         Name: animal, dtype: bool
 
         >>> s.rename("a").to_frame().set_index("a").index.isin(['lama'])
-        Index([True, False, True, False, True, False], dtype='object', name='a')
+        Index([True, False, True, False, True, False], dtype='bool', name='a')

Review Comment:
   FYI: I included the fix for SPARK-40576 here and below since it's sort of minor fix, and I believe it's the last one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org