[GitHub] [ignite] timoninmaxim commented on a change in pull request #7852: IGNITE-13051 still validate MVCC if cache will not start

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #7852:
URL: https://github.com/apache/ignite/pull/7852#discussion_r433080720



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccConfigurationValidationTest.java
##########
@@ -322,6 +325,33 @@ public void testTransactionalSnapshotLimitations() throws Exception {
         );
     }
 
+    /**
+     * Check that node in client mode (filtered by AttributeNodeFilter) correctly works with MVCC.
+     */
+    @SuppressWarnings("unchecked")
+    @Test
+    public void testMvccEnabledForClientMode() throws Exception {
+        String attrName = "has_cache";
+        Object attrVal = Boolean.TRUE;
+
+        final IgniteEx crd = (IgniteEx) startGrid(getTestIgniteInstanceName(0), getConfiguration());
+
+        // Do not start cache on non-affinity node.
+        CacheConfiguration ccfg = defaultCacheConfiguration()

Review comment:
       Hi, this test checks that MVCC mode is enabled, so atomicity mode is required for testing. Near must be set to null with enabled MVCC. Backups doesn't matter actually, I'll fix it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org