You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 23:31:59 UTC

Review Request 67778: Fixed flaky test `DefaultExecutorTest.SigkillExecutor`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67778/
-----------------------------------------------------------

Review request for mesos and Chun-Hung Hsiao.


Bugs: MESOS-9037
    https://issues.apache.org/jira/browse/MESOS-9037


Repository: mesos


Description
-------

Fixed flaky test `DefaultExecutorTest.SigkillExecutor`
by setting action to ignore subsequent offer calls.


Diffs
-----

  src/tests/default_executor_tests.cpp cd7e26368f83e7142dcdc08d30b9282da4a43d89 


Diff: https://reviews.apache.org/r/67778/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Re: Review Request 67778: Fixed flaky test `DefaultExecutorTest.SigkillExecutor`.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67778/#review205540
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On June 28, 2018, 11:31 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67778/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 11:31 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9037
>     https://issues.apache.org/jira/browse/MESOS-9037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flaky test `DefaultExecutorTest.SigkillExecutor`
> by setting action to ignore subsequent offer calls.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp cd7e26368f83e7142dcdc08d30b9282da4a43d89 
> 
> 
> Diff: https://reviews.apache.org/r/67778/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>