You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/23 13:07:10 UTC

[GitHub] MaxGekk opened a new pull request #23878: [SPARK-26978][CORE] Avoid magic time constants

MaxGekk opened a new pull request #23878: [SPARK-26978][CORE] Avoid magic time constants
URL: https://github.com/apache/spark/pull/23878
 
 
   ## What changes were proposed in this pull request?
   
   In the PR, I propose to refactor existing code related to date/time conversions, and replace constants like `1000` and `1000000` by `DateTimeUtils` constants and transformation functions from `java.util.concurrent.TimeUnit._`.
   
   ## How was this patch tested?
   
   The changes are tested by existing test suites.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org