svn commit: r681705 - /james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java

[ba...@apache.org]

Author: bago
Date: Fri Aug  1 07:29:53 2008
New Revision: 681705

URL: http://svn.apache.org/viewvc?rev=681705&view=rev
Log:
Identified a possible "wait forever" issue in the disabled runMulti test (wait(random) where random was sometimes 0).
Modified it to wait(random+1) and reenabled the test.

Modified:
    james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java

Modified: james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java?rev=681705&r1=681704&r2=681705&view=diff
==============================================================================
--- james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java (original)
+++ james/server/trunk/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/AbstractRemoteDeliveryTest.java Fri Aug  1 07:29:53 2008
@@ -96,13 +96,9 @@
         if (doTest == 0 || doTest == 10) doTest10(getDeliverer(), getParameters());
     }
 
-    /* Temporarily disabled. Maybe this randomly fails
-     * It's not clear if the issue is THIS specific test and if the random
-     * problem is in the RemoteDelivery code or in the test suite. 
     public void testMulti() throws Exception {
         if (doTest == 0 || doTest == -1) doTestMulti(getDeliverer(), getParameters());
     }
-    */
     
     protected void initEnvironment() {
         // Generate mock environment
@@ -717,7 +713,7 @@
             results[i] = tester.service("M" + i, i + "@test.it", (String[]) rcpts.toArray(new String[0]), "Subject: test" + i + "\r\nContent-Transfer-Encoding: plain\r\n\r\nbody");
             synchronized(this) {
                 if (loopWait > 0) wait(loopWait);
-                if (loopWaitRandom > 0) wait(rnd.nextInt(loopWaitRandom));
+                if (loopWaitRandom > 0) wait(rnd.nextInt(loopWaitRandom)+1);
             }
         }
         



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org