You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/01/14 00:11:28 UTC

zeppelin git commit: [HOTFIX] Does not working settings menu in zeppelin web graph ui

Repository: zeppelin
Updated Branches:
  refs/heads/master 068c89462 -> 59e15c03d


[HOTFIX] Does not working settings menu in zeppelin web graph ui

### What is this PR for?
Does not working settings menu in zeppelin web graph ui

### What type of PR is it?
Bug Fix

### How should this be tested?
1. toggle settings menu in zeppelin graph ui

### Screenshots (if appropriate)
#### Before
![incorrect](https://cloud.githubusercontent.com/assets/10525473/21949815/1733ed6a-d9aa-11e6-92c8-8da98200cf43.gif)

#### After
![correct](https://cloud.githubusercontent.com/assets/10525473/21949805/045c9a34-d9aa-11e6-86dc-445ce229f2a8.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: cloverhearts <cl...@gmail.com>

Closes #1899 from cloverhearts/ZEEPELIN-SETTING-PROBLEM-WEB-UI and squashes the following commits:

e3453b7 [cloverhearts] invalid render life cycle for setting


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/59e15c03
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/59e15c03
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/59e15c03

Branch: refs/heads/master
Commit: 59e15c03d6a405e07dec59fb6e7f0ad87150794f
Parents: 068c894
Author: cloverhearts <cl...@gmail.com>
Authored: Fri Jan 13 16:02:55 2017 -0800
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Jan 13 16:11:12 2017 -0800

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/result/result.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/59e15c03/zeppelin-web/src/app/notebook/paragraph/result/result.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.html b/zeppelin-web/src/app/notebook/paragraph/result/result.html
index 97d453a..df09c4d 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.html
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.html
@@ -24,7 +24,7 @@ limitations under the License.
     <div ng-if="type=='TABLE'">
       <!-- graph setting -->
       <div class="option lightBold" style="overflow: visible;"
-           ng-if="graphMode!='table'
+           ng-show="graphMode!='table'
                     && config.graph.optionOpen && !asIframe && !viewOnly">
         <div ng-repeat="viz in builtInTableDataVisualizationList track by $index"
              id="trsetting{{id}}_{{viz.id}}"