You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2018/01/03 14:13:00 UTC
[jira] [Commented] (HADOOP-15154) Abstract new method
assertCapability for StreamCapabilities testing
[ https://issues.apache.org/jira/browse/HADOOP-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309696#comment-16309696 ]
Steve Loughran commented on HADOOP-15154:
-----------------------------------------
How about: static and in ContractTestUtils?
> Abstract new method assertCapability for StreamCapabilities testing
> -------------------------------------------------------------------
>
> Key: HADOOP-15154
> URL: https://issues.apache.org/jira/browse/HADOOP-15154
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Xiao Chen
> Priority: Minor
>
> From Steve's [comment|https://issues.apache.org/jira/browse/HADOOP-15149?focusedCommentId=16306806&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16306806]:
> bq. it'd have been cleaner for the asserts to have been one in a assertCapability(key, StreamCapabilities subject, bool outcome) and had it throw meaningful exceptions on a failure
> We can consider abstract such a method to a test util class and use it for all {{StreamCapabilities}} tests as needed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org