You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/10/09 02:37:12 UTC
Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/
-----------------------------------------------------------
Review request for mesos and Kapil Arya.
Bugs: MESOS-3553
https://issues.apache.org/jira/browse/MESOS-3553
Repository: mesos
Description
-------
If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
Diffs
-----
src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
Diff: https://reviews.apache.org/r/39152/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Oct. 9, 2015, 12:46 a.m., Neil Conway wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 307
> > <https://reviews.apache.org/r/39152/diff/1/?file=1093416#file1093416line307>
> >
> > Modifying the environment doesn't seem like a great thing for a test to be doing, since it might impact other tests -- we should at least reset LIBPROCESS_IP to its previous value at the end of the test. That still isn't great (e.g., if we want to run multiple tests concurrently in the same OS process), but I'm not sure there's a better way.
Good call, thanks Neil!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review101992
-----------------------------------------------------------
On Oct. 9, 2015, 12:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
> src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
>
> Diff: https://reviews.apache.org/r/39152/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review101992
-----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp (line 307)
<https://reviews.apache.org/r/39152/#comment159517>
Modifying the environment doesn't seem like a great thing for a test to be doing, since it might impact other tests -- we should at least reset LIBPROCESS_IP to its previous value at the end of the test. That still isn't great (e.g., if we want to run multiple tests concurrently in the same OS process), but I'm not sure there's a better way.
- Neil Conway
On Oct. 9, 2015, 12:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 12:37 a.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
> src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
>
> Diff: https://reviews.apache.org/r/39152/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 8:33 p.m.)
Review request for mesos and Kapil Arya.
Changes
-------
Changed conditional in test.
Bugs: MESOS-3553
https://issues.apache.org/jira/browse/MESOS-3553
Repository: mesos
Description
-------
If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
Diff: https://reviews.apache.org/r/39152/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review102098
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Oct. 8, 2015, 8:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 8:57 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
> src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
>
> Diff: https://reviews.apache.org/r/39152/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review102021
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39152]
All tests passed.
- Mesos ReviewBot
On Oct. 9, 2015, 12:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
> src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
>
> Diff: https://reviews.apache.org/r/39152/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review102094
-----------------------------------------------------------
LGTM!
- Cody Maloney
On Oct. 9, 2015, 12:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
> src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
>
> Diff: https://reviews.apache.org/r/39152/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 39152: Pass LIBPROCESS_IP even when executor
environment is specified.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 12:57 a.m.)
Review request for mesos and Kapil Arya.
Changes
-------
Addressed comment.
Bugs: MESOS-3553
https://issues.apache.org/jira/browse/MESOS-3553
Repository: mesos
Description
-------
If DNS is not available on the agent node and a task is launched which explicitly specifies the executor's environment, LIBPROCESS_IP will not be passed through and the default hostname lookup after spawning the executor process will throw an error. This patch alters the agent to always pass LIBPROCESS_IP, even when the executor environment is specified.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c
src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
Diff: https://reviews.apache.org/r/39152/diff/
Testing
-------
`make check`
Thanks,
Greg Mann