You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/06/24 05:18:19 UTC

[PR] Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries" [spark]

LuciferYang opened a new pull request, #51261:
URL: https://github.com/apache/spark/pull/51261

   ### What changes were proposed in this pull request?
   This PR reverts the example code provided in SPARK-50849 because it fails to compile properly.
   
   
   ### Why are the changes needed?
   An example that fails to compile properly should not be provided to users.
   
   The following error occurs when executing `mvn clean install -DskipTests` in the `connect-examples/server-library-example `directory:
   
   ```
   [ERROR] /Users/yangjie01/SourceCode/git/spark-maven/connect-examples/server-library-example/client/src/main/scala/org/apache/connect/examples/serverlibrary/CustomTable.scala:87: overloaded method setExtension with alternatives:
     (x$1: org.sparkproject.com.google.protobuf.Any.Builder)org.apache.spark.connect.proto.Command.Builder <and>
     (x$1: org.sparkproject.com.google.protobuf.Any)org.apache.spark.connect.proto.Command.Builder
    cannot be applied to (com.google.protobuf.Any)
   [ERROR] /Users/yangjie01/SourceCode/git/spark-maven/connect-examples/server-library-example/client/src/main/scala/org/apache/connect/examples/serverlibrary/CustomTable.scala:115: overloaded method setExtension with alternatives:
     (x$1: org.sparkproject.com.google.protobuf.Any.Builder)org.apache.spark.connect.proto.Relation.Builder <and>
     (x$1: org.sparkproject.com.google.protobuf.Any)org.apache.spark.connect.proto.Relation.Builder
    cannot be applied to (com.google.protobuf.Any)
   [ERROR] /Users/yangjie01/SourceCode/git/spark-maven/connect-examples/server-library-example/client/src/main/scala/org/apache/connect/examples/serverlibrary/CustomTableBuilder.scala:115: overloaded method setExtension with alternatives:
     (x$1: org.sparkproject.com.google.protobuf.Any.Builder)org.apache.spark.connect.proto.Command.Builder <and>
     (x$1: org.sparkproject.com.google.protobuf.Any)org.apache.spark.connect.proto.Command.Builder
    cannot be applied to (com.google.protobuf.Any)
   [ERROR] three errors found
   
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   - Pass GitHub Actions
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries" [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #51261: Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries"
URL: https://github.com/apache/spark/pull/51261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries" [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51261:
URL: https://github.com/apache/spark/pull/51261#issuecomment-2998857930

   We can wait for it to be fixed and then merge it back in again.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries" [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51261:
URL: https://github.com/apache/spark/pull/51261#issuecomment-2998860316

   cc @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] Revert "[SPARK-50849][CONNECT] Add example project to demonstrate Spark Connect Server Libraries" [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51261:
URL: https://github.com/apache/spark/pull/51261#issuecomment-3000535554

   Merged into master and branch-4.0.Thanks @yaooqinn and @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org